lint

Author: nicohrubec

packages/core/src/attributes.ts

@@ -63,10 +63,9 @@ export function isAttributeObject(maybeObj: unknown): maybeObj is AttributeObjec
 /**
  * Converts an attribute value to a typed attribute value.
  *
- * For now, we support primitive values, homogeneous arrays of primitives, and attribute objects
- * with primitive or primitive-array values. If @param useFallback is true, we stringify other
- * non-primitive values to a string attribute value. Otherwise we return `undefined` for unsupported
- * values.
+ * For now, we support primitive values and homogeneous arrays of primitives, either raw or
+ * inside attribute objects. If @param useFallback is true, we stringify other non-primitive values
+ * to a string attribute value. Otherwise we return `undefined` for unsupported values.
  *
  * @param value - The value of the passed attribute.
  * @param useFallback - If true, unsupported values will be stringified to a string attribute value.

packages/core/test/lib/attributes.test.ts

@@ -77,15 +77,13 @@ describe('attributeValueToTypedAttributeValue', () => {
     });
 
     describe('homogeneous primitive arrays', () => {
-      it.each([
-        [['foo', 'bar']],
-        [[1, 2, 3]],
-        [[true, false, true]],
-        [[] as unknown[]],
-      ])('emits a typed array attribute for raw value %j', value => {
-        const result = attributeValueToTypedAttributeValue(value);
-        expect(result).toStrictEqual({ value, type: 'array' });
-      });
+      it.each([[['foo', 'bar']], [[1, 2, 3]], [[true, false, true]], [[] as unknown[]]])(
+        'emits a typed array attribute for raw value %j',
+        value => {
+          const result = attributeValueToTypedAttributeValue(value);
+          expect(result).toStrictEqual({ value, type: 'array' });
+        },
+      );
 
       it('emits a typed array attribute for attribute object values', () => {
         const result = attributeValueToTypedAttributeValue({ value: ['foo', 'bar'] });
@@ -94,25 +92,21 @@ describe('attributeValueToTypedAttributeValue', () => {
     });
 
     describe('invalid values (non-primitives)', () => {
-      it.each([
-        [[1, 'foo', true]],
-        [{ foo: 'bar' }],
-        [() => 'test'],
-        [Symbol('test')],
-      ])('returns undefined for non-primitive raw values (%s)', value => {
-        const result = attributeValueToTypedAttributeValue(value);
-        expect(result).toBeUndefined();
-      });
+      it.each([[[1, 'foo', true]], [{ foo: 'bar' }], [() => 'test'], [Symbol('test')]])(
+        'returns undefined for non-primitive raw values (%s)',
+        value => {
+          const result = attributeValueToTypedAttributeValue(value);
+          expect(result).toBeUndefined();
+        },
+      );
 
-      it.each([
-        [[1, 'foo', true]],
-        [{ foo: 'bar' }],
-        [() => 'test'],
-        [Symbol('test')],
-      ])('returns undefined for non-primitive attribute object values (%s)', value => {
-        const result = attributeValueToTypedAttributeValue({ value });
-        expect(result).toBeUndefined();
-      });
+      it.each([[[1, 'foo', true]], [{ foo: 'bar' }], [() => 'test'], [Symbol('test')]])(
+        'returns undefined for non-primitive attribute object values (%s)',
+        value => {
+          const result = attributeValueToTypedAttributeValue({ value });
+          expect(result).toBeUndefined();
+        },
+      );
     });
   });