fix overwrite object

Author: s1gr1d

packages/nuxt/src/vite/sourceMaps.ts

@@ -38,7 +38,7 @@ export function setupSourceMaps(
           (sourceMapsUploadOptions.enabled ?? true);
 
   // In case we overwrite the source map settings, we default to deleting the files
-  let shouldDeleteFilesFallback = { client: true, server: true };
+  const shouldDeleteFilesFallback = { client: true, server: true };
 
   nuxt.hook('modules:done', () => {
     if (sourceMapsEnabled && !nuxt.options.dev && !nuxt.options?._prepare) {
@@ -47,13 +47,12 @@ export function setupSourceMaps(
       // - for server to viteConfig.build.sourceMap and nitro.sourceMap
       // On server, nitro.rollupConfig.output.sourcemap remains unaffected from this change.
 
-      // ONLY THIS nuxt.sourcemap.(server/client) setting is the one Sentry will eventually overwrite with 'hidden'
+      // ONLY THIS nuxt.sourcemap.(server/client) setting is the one Sentry will overwrite with 'hidden', if needed.
       const previousSourceMapSettings = changeNuxtSourceMapSettings(nuxt, moduleOptions);
 
-      shouldDeleteFilesFallback = {
-        client: previousSourceMapSettings.client === 'unset',
-        server: previousSourceMapSettings.server === 'unset',
-      };
+      // Mutate in place so the Vite plugin (which captured this object at registration time) sees the updated values
+      shouldDeleteFilesFallback.client = previousSourceMapSettings.client === 'unset';
+      shouldDeleteFilesFallback.server = previousSourceMapSettings.server === 'unset';
 
       if (isDebug && (shouldDeleteFilesFallback.client || shouldDeleteFilesFallback.server)) {
         const enabledDeleteFallbacks =

packages/nuxt/test/vite/sourceMaps-nuxtHooks.test.ts

@@ -76,17 +76,17 @@ describe('setupSourceMaps hooks', () => {
   });
 
   describe('vite plugin registration', () => {
-    it('registers a vite plugin after modules:done hook', async () => {
+    it('calls `addVitePlugin` when setupSourceMaps is called', async () => {
       const { setupSourceMaps } = await import('../../src/vite/sourceMaps');
       const mockNuxt = createMockNuxt({ _prepare: false, dev: false });
       const { mockAddVitePlugin, getCapturedPlugin } = createMockAddVitePlugin();
 
       setupSourceMaps({ debug: true }, mockNuxt as unknown as Nuxt, mockAddVitePlugin);
-      await mockNuxt.triggerHook('modules:done');
 
       const plugin = getCapturedPlugin();
       expect(plugin).not.toBeNull();
       expect(plugin?.name).toBe('sentry-nuxt-vite-config');
+      // modules:done is called afterward. Later, the plugin is actually added
     });
 
     it.each([
@@ -179,6 +179,66 @@ describe('setupSourceMaps hooks', () => {
     });
   });
 
+  describe('shouldDeleteFilesFallback passed to getPluginOptions in Vite plugin', () => {
+    const defaultFilesToDeleteAfterUpload = [
+      '.*/**/public/**/*.map',
+      '.*/**/server/**/*.map',
+      '.*/**/output/**/*.map',
+      '.*/**/function/**/*.map',
+    ];
+
+    it('uses mutated shouldDeleteFilesFallback (unset → true): plugin.config() after modules:done gets fallback filesToDeleteAfterUpload', async () => {
+      const { setupSourceMaps } = await import('../../src/vite/sourceMaps');
+      const mockNuxt = createMockNuxt({
+        _prepare: false,
+        dev: false,
+        sourcemap: { client: undefined, server: undefined },
+      });
+      const { mockAddVitePlugin, getCapturedPlugin } = createMockAddVitePlugin();
+
+      setupSourceMaps({ debug: false }, mockNuxt as unknown as Nuxt, mockAddVitePlugin);
+      await mockNuxt.triggerHook('modules:done');
+
+      const plugin = getCapturedPlugin();
+      expect(plugin).not.toBeNull();
+      if (plugin && typeof plugin.config === 'function') {
+        plugin.config({ build: { ssr: false }, plugins: [] }, { mode: 'production', command: 'build' });
+      }
+
+      expect(mockSentryVitePlugin).toHaveBeenCalledWith(
+        expect.objectContaining({
+          sourcemaps: expect.objectContaining({
+            filesToDeleteAfterUpload: defaultFilesToDeleteAfterUpload,
+          }),
+        }),
+      );
+    });
+
+    it('uses mutated shouldDeleteFilesFallback (explicitly enabled → false): plugin.config() after modules:done gets no filesToDeleteAfterUpload', async () => {
+      const { setupSourceMaps } = await import('../../src/vite/sourceMaps');
+      const mockNuxt = createMockNuxt({
+        _prepare: false,
+        dev: false,
+        sourcemap: { client: true, server: true },
+      });
+      const { mockAddVitePlugin, getCapturedPlugin } = createMockAddVitePlugin();
+
+      setupSourceMaps({ debug: false }, mockNuxt as unknown as Nuxt, mockAddVitePlugin);
+      await mockNuxt.triggerHook('modules:done');
+
+      const plugin = getCapturedPlugin();
+      expect(plugin).not.toBeNull();
+      if (plugin && typeof plugin.config === 'function') {
+        plugin.config({ build: { ssr: false }, plugins: [] }, { mode: 'production', command: 'build' });
+      }
+
+      const pluginOptions = (mockSentryVitePlugin?.mock?.calls?.[0] as unknown[])?.[0] as {
+        sourcemaps?: { filesToDeleteAfterUpload?: string[] };
+      };
+      expect(pluginOptions?.sourcemaps?.filesToDeleteAfterUpload).toBeUndefined();
+    });
+  });
+
   describe('nitro:config hook', () => {
     it('adds sentryRollupPlugin to nitro rollup config in production mode', async () => {
       const { setupSourceMaps } = await import('../../src/vite/sourceMaps');