fix: skip sourcemap upload hooks early

Author: logaretm

packages/nitro/src/sourceMaps.ts

@@ -9,18 +9,7 @@ import type { SentryNitroOptions } from './config';
 export function setupSourceMaps(nitro: Nitro, options?: SentryNitroOptions, sentryEnabledSourcemaps?: boolean): void {
   // The `compiled` hook fires on EVERY rebuild during `nitro dev` watch mode.
   // nitro.options.dev is reliably set by the time module setup runs.
-  if (nitro.options.dev) {
-    return;
-  }
-
-  // Nitro spawns a nested Nitro instance for prerendering with the user's `modules` re-installed.
-  // Uploading here would double-upload source maps and create a duplicate release.
-  if (nitro.options.preset === 'nitro-prerender') {
-    return;
-  }
-
-  // Respect user's explicit disable
-  if (options?.sourcemaps?.disable === true) {
+  if (shouldSkipSourcemapUpload(nitro, options)) {
     return;
   }
 
@@ -29,6 +18,18 @@ export function setupSourceMaps(nitro: Nitro, options?: SentryNitroOptions, sent
   });
 }
 
+/**
+ * Determines if sourcemap uploads should be skipped.
+ */
+function shouldSkipSourcemapUpload(nitro: Nitro, options?: SentryNitroOptions): boolean {
+  return !!(
+    nitro.options.dev ||
+    nitro.options.preset === 'nitro-prerender' ||
+    nitro.options.sourcemap === false ||
+    options?.sourcemaps?.disable === true
+  );
+}
+
 /**
  * Handles the actual source map upload after the build completes.
  */

packages/nitro/test/sourceMaps.test.ts

@@ -274,6 +274,18 @@ describe('setupSourceMaps', () => {
     expect(hookFn).not.toHaveBeenCalled();
   });
 
+  it('does not register hook when nitro sourcemap is disabled', () => {
+    const hookFn = vi.fn();
+    const nitro = {
+      options: { dev: false, sourcemap: false, output: { serverDir: '/output/server' } },
+      hooks: { hook: hookFn },
+    } as any;
+
+    setupSourceMaps(nitro);
+
+    expect(hookFn).not.toHaveBeenCalled();
+  });
+
   it('does not register hook in nitro-prerender preset', () => {
     const hookFn = vi.fn();
     const nitro = {