Skip to content

Commit 5fd99df

Browse files
mydeaclaude
andcommitted
fix(ci): Use container.env instead of -e flag for HOME=/root
The -e flag in container options gets overridden by GitHub Actions. Use container.env which is the proper way to set environment variables inside job containers and takes precedence over the Actions default. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent c5cca34 commit 5fd99df

File tree

3 files changed

+21
-7
lines changed

3 files changed

+21
-7
lines changed

.github/workflows/build.yml

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -501,7 +501,9 @@ jobs:
501501
credentials:
502502
username: ${{ github.actor }}
503503
password: ${{ secrets.GITHUB_TOKEN }}
504-
options: --ipc=host -e HOME=/root
504+
options: --ipc=host
505+
env:
506+
HOME: /root
505507
timeout-minutes: 25
506508
strategy:
507509
fail-fast: false
@@ -605,7 +607,9 @@ jobs:
605607
credentials:
606608
username: ${{ github.actor }}
607609
password: ${{ secrets.GITHUB_TOKEN }}
608-
options: --ipc=host -e HOME=/root
610+
options: --ipc=host
611+
env:
612+
HOME: /root
609613
timeout-minutes: 15
610614
strategy:
611615
fail-fast: false
@@ -799,7 +803,9 @@ jobs:
799803
credentials:
800804
username: ${{ github.actor }}
801805
password: ${{ secrets.GITHUB_TOKEN }}
802-
options: --ipc=host -e HOME=/root
806+
options: --ipc=host
807+
env:
808+
HOME: /root
803809
timeout-minutes: 15
804810
strategy:
805811
fail-fast: false
@@ -902,7 +908,9 @@ jobs:
902908
credentials:
903909
username: ${{ github.actor }}
904910
password: ${{ secrets.GITHUB_TOKEN }}
905-
options: --ipc=host -e HOME=/root
911+
options: --ipc=host
912+
env:
913+
HOME: /root
906914
timeout-minutes: 15
907915
env:
908916
# We just use a dummy DSN here, only send to the tunnel anyhow
@@ -1033,7 +1041,9 @@ jobs:
10331041
credentials:
10341042
username: ${{ github.actor }}
10351043
password: ${{ secrets.GITHUB_TOKEN }}
1036-
options: --ipc=host -e HOME=/root
1044+
options: --ipc=host
1045+
env:
1046+
HOME: /root
10371047
timeout-minutes: 15
10381048
env:
10391049
E2E_TEST_AUTH_TOKEN: ${{ secrets.E2E_TEST_AUTH_TOKEN }}

.github/workflows/canary.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,9 @@ jobs:
7676
credentials:
7777
username: ${{ github.actor }}
7878
password: ${{ secrets.GITHUB_TOKEN }}
79-
options: --ipc=host -e HOME=/root
79+
options: --ipc=host
80+
env:
81+
HOME: /root
8082
timeout-minutes: 20
8183
env:
8284
# We just use a dummy DSN here, only send to the tunnel anyhow

.github/workflows/flaky-test-detector.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,9 @@ jobs:
4545
credentials:
4646
username: ${{ github.actor }}
4747
password: ${{ secrets.GITHUB_TOKEN }}
48-
options: --ipc=host -e HOME=/root
48+
options: --ipc=host
49+
env:
50+
HOME: /root
4951
timeout-minutes: 60
5052
name: 'Check tests for flakiness'
5153
# Also skip if PR is from master -> develop

0 commit comments

Comments
 (0)