Skip to content

Commit 79be1ef

Browse files
committed
test(effect): Rename effect e2e tests to a versioned folder (#20390)
This PR is only renaming Effect v3 e2e tests, which had no versioning, to one with a version. This makes it easier in the future to distinguish between Effect v3 and v4 tests. So effectively this has changed: - `effect-node` -> `effect-3-node` - `effect-browser` -> `effect-3-browser`
1 parent a87183e commit 79be1ef

File tree

22 files changed

+30
-30
lines changed

22 files changed

+30
-30
lines changed

dev-packages/e2e-tests/test-applications/effect-browser/.gitignore renamed to dev-packages/e2e-tests/test-applications/effect-3-browser/.gitignore

File renamed without changes.

dev-packages/e2e-tests/test-applications/effect-browser/.npmrc renamed to dev-packages/e2e-tests/test-applications/effect-3-browser/.npmrc

File renamed without changes.

dev-packages/e2e-tests/test-applications/effect-browser/build.mjs renamed to dev-packages/e2e-tests/test-applications/effect-3-browser/build.mjs

File renamed without changes.

dev-packages/e2e-tests/test-applications/effect-browser/package.json renamed to dev-packages/e2e-tests/test-applications/effect-3-browser/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "effect-browser-test-app",
2+
"name": "effect-3-browser-test-app",
33
"version": "1.0.0",
44
"private": true,
55
"scripts": {

dev-packages/e2e-tests/test-applications/effect-browser/playwright.config.mjs renamed to dev-packages/e2e-tests/test-applications/effect-3-browser/playwright.config.mjs

File renamed without changes.

dev-packages/e2e-tests/test-applications/effect-browser/public/index.html renamed to dev-packages/e2e-tests/test-applications/effect-3-browser/public/index.html

File renamed without changes.

dev-packages/e2e-tests/test-applications/effect-browser/src/index.js renamed to dev-packages/e2e-tests/test-applications/effect-3-browser/src/index.js

File renamed without changes.

dev-packages/e2e-tests/test-applications/effect-browser/start-event-proxy.mjs renamed to dev-packages/e2e-tests/test-applications/effect-3-browser/start-event-proxy.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ import { startEventProxyServer } from '@sentry-internal/test-utils';
22

33
startEventProxyServer({
44
port: 3031,
5-
proxyServerName: 'effect-browser',
5+
proxyServerName: 'effect-3-browser',
66
});

dev-packages/e2e-tests/test-applications/effect-browser/tests/errors.test.ts renamed to dev-packages/e2e-tests/test-applications/effect-3-browser/tests/errors.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { expect, test } from '@playwright/test';
22
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
33

44
test('captures an error', async ({ page }) => {
5-
const errorEventPromise = waitForError('effect-browser', event => {
5+
const errorEventPromise = waitForError('effect-3-browser', event => {
66
return !event.type && event.exception?.values?.[0]?.value === 'I am an error!';
77
});
88

@@ -29,11 +29,11 @@ test('captures an error', async ({ page }) => {
2929
});
3030

3131
test('sets correct transactionName', async ({ page }) => {
32-
const transactionPromise = waitForTransaction('effect-browser', async transactionEvent => {
32+
const transactionPromise = waitForTransaction('effect-3-browser', async transactionEvent => {
3333
return !!transactionEvent?.transaction && transactionEvent.contexts?.trace?.op === 'pageload';
3434
});
3535

36-
const errorEventPromise = waitForError('effect-browser', event => {
36+
const errorEventPromise = waitForError('effect-3-browser', event => {
3737
return !event.type && event.exception?.values?.[0]?.value === 'I am an error!';
3838
});
3939

dev-packages/e2e-tests/test-applications/effect-browser/tests/logs.test.ts renamed to dev-packages/e2e-tests/test-applications/effect-3-browser/tests/logs.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { waitForEnvelopeItem } from '@sentry-internal/test-utils';
33
import type { SerializedLogContainer } from '@sentry/core';
44

55
test('should send Effect debug logs', async ({ page }) => {
6-
const logEnvelopePromise = waitForEnvelopeItem('effect-browser', envelope => {
6+
const logEnvelopePromise = waitForEnvelopeItem('effect-3-browser', envelope => {
77
return (
88
envelope[0].type === 'log' &&
99
(envelope[1] as SerializedLogContainer).items.some(
@@ -26,7 +26,7 @@ test('should send Effect debug logs', async ({ page }) => {
2626
});
2727

2828
test('should send Effect info logs', async ({ page }) => {
29-
const logEnvelopePromise = waitForEnvelopeItem('effect-browser', envelope => {
29+
const logEnvelopePromise = waitForEnvelopeItem('effect-3-browser', envelope => {
3030
return (
3131
envelope[0].type === 'log' &&
3232
(envelope[1] as SerializedLogContainer).items.some(
@@ -49,7 +49,7 @@ test('should send Effect info logs', async ({ page }) => {
4949
});
5050

5151
test('should send Effect warning logs', async ({ page }) => {
52-
const logEnvelopePromise = waitForEnvelopeItem('effect-browser', envelope => {
52+
const logEnvelopePromise = waitForEnvelopeItem('effect-3-browser', envelope => {
5353
return (
5454
envelope[0].type === 'log' &&
5555
(envelope[1] as SerializedLogContainer).items.some(
@@ -72,7 +72,7 @@ test('should send Effect warning logs', async ({ page }) => {
7272
});
7373

7474
test('should send Effect error logs', async ({ page }) => {
75-
const logEnvelopePromise = waitForEnvelopeItem('effect-browser', envelope => {
75+
const logEnvelopePromise = waitForEnvelopeItem('effect-3-browser', envelope => {
7676
return (
7777
envelope[0].type === 'log' &&
7878
(envelope[1] as SerializedLogContainer).items.some(
@@ -95,7 +95,7 @@ test('should send Effect error logs', async ({ page }) => {
9595
});
9696

9797
test('should send Effect logs with context attributes', async ({ page }) => {
98-
const logEnvelopePromise = waitForEnvelopeItem('effect-browser', envelope => {
98+
const logEnvelopePromise = waitForEnvelopeItem('effect-3-browser', envelope => {
9999
return (
100100
envelope[0].type === 'log' &&
101101
(envelope[1] as SerializedLogContainer).items.some(item => item.body === 'Log with context')

0 commit comments

Comments
 (0)