fix(core): Record client report with reason for HTTP 413 responses

Author: logaretm

.size-limit.js

@@ -82,7 +82,7 @@ module.exports = [
     path: 'packages/browser/build/npm/esm/prod/index.js',
     import: createImport('init', 'browserTracingIntegration', 'replayIntegration', 'replayCanvasIntegration'),
     gzip: true,
-    limit: '85.5 KB',
+    limit: '85.55 KB',
   },
   {
     name: '@sentry/browser (incl. Tracing, Replay, Feedback)',

packages/core/src/transports/base.ts

@@ -71,6 +71,18 @@ export function createTransport(
     const requestTask = (): PromiseLike<TransportMakeRequestResponse> =>
       makeRequest({ body: serializeEnvelope(filteredEnvelope) }).then(
         response => {
+          // Handle 413 Content Too Large
+          // Loss of envelope content is expected so we record a send_error client report
+          // https://develop.sentry.dev/sdk/expected-features/#dealing-with-network-failures
+          if (response.statusCode === 413) {
+            DEBUG_BUILD &&
+              debug.error(
+                'Sentry responded with status code 413. Envelope was discarded due to exceeding size limits.',
+              );
+            recordEnvelopeLoss('send_error');
+            return response;
+          }
+
           // We don't want to throw on NOK responses, but we want to at least log them
           if (response.statusCode !== undefined && (response.statusCode < 200 || response.statusCode >= 300)) {
             DEBUG_BUILD && debug.warn(`Sentry responded with status code ${response.statusCode} to sent event.`);

packages/core/test/lib/transports/base.test.ts

@@ -391,5 +391,81 @@ describe('createTransport', () => {
         expect(mockRecordDroppedEventCallback).toHaveBeenCalledWith('network_error', 'error');
       });
     });
+
+    describe('HTTP 413 Content Too Large', () => {
+      it('should record send_error outcome when receiving 413 response', async () => {
+        const mockRecordDroppedEventCallback = vi.fn();
+
+        const transport = createTransport({ recordDroppedEvent: mockRecordDroppedEventCallback }, () =>
+          resolvedSyncPromise({ statusCode: 413 }),
+        );
+
+        const result = await transport.send(ERROR_ENVELOPE);
+
+        // Should resolve without throwing
+        expect(result).toEqual({ statusCode: 413 });
+        // recordDroppedEvent SHOULD be called with send_error reason
+        expect(mockRecordDroppedEventCallback).toHaveBeenCalledWith('send_error', 'error');
+      });
+
+      it('should record send_error for each item in envelope when receiving 413', async () => {
+        const mockRecordDroppedEventCallback = vi.fn();
+
+        const multiItemEnvelope = createEnvelope<EventEnvelope>(
+          { event_id: 'aa3ff046696b4bc6b609ce6d28fde9e2', sent_at: '123' },
+          [
+            [{ type: 'event' }, { event_id: 'aa3ff046696b4bc6b609ce6d28fde9e2' }] as EventItem,
+            [{ type: 'transaction' }, { event_id: 'bb3ff046696b4bc6b609ce6d28fde9e2' }] as EventItem,
+          ],
+        );
+
+        const transport = createTransport({ recordDroppedEvent: mockRecordDroppedEventCallback }, () =>
+          resolvedSyncPromise({ statusCode: 413 }),
+        );
+
+        await transport.send(multiItemEnvelope);
+
+        // recordDroppedEvent SHOULD be called for each item
+        expect(mockRecordDroppedEventCallback).toHaveBeenCalledTimes(2);
+        expect(mockRecordDroppedEventCallback).toHaveBeenCalledWith('send_error', 'error');
+        expect(mockRecordDroppedEventCallback).toHaveBeenCalledWith('send_error', 'transaction');
+      });
+
+      it('should not record outcomes for client reports when receiving 413', async () => {
+        const mockRecordDroppedEventCallback = vi.fn();
+
+        const transport = createTransport({ recordDroppedEvent: mockRecordDroppedEventCallback }, () =>
+          resolvedSyncPromise({ statusCode: 413 }),
+        );
+
+        const result = await transport.send(CLIENT_REPORT_ENVELOPE);
+
+        // Should resolve without throwing
+        expect(result).toEqual({ statusCode: 413 });
+        // recordDroppedEvent should NOT be called for client reports to avoid feedback loop
+        expect(mockRecordDroppedEventCallback).not.toHaveBeenCalled();
+      });
+
+      it('should not apply rate limits after receiving 413', async () => {
+        const mockRecordDroppedEventCallback = vi.fn();
+        const mockRequestExecutor = vi.fn(() => resolvedSyncPromise({ statusCode: 413 }));
+
+        const transport = createTransport({ recordDroppedEvent: mockRecordDroppedEventCallback }, mockRequestExecutor);
+
+        // First request gets 413
+        await transport.send(ERROR_ENVELOPE);
+        expect(mockRequestExecutor).toHaveBeenCalledTimes(1);
+        expect(mockRecordDroppedEventCallback).toHaveBeenCalledWith('send_error', 'error');
+        mockRequestExecutor.mockClear();
+        mockRecordDroppedEventCallback.mockClear();
+
+        // Second request should still be sent (no rate limiting applied from 413)
+        mockRequestExecutor.mockImplementation(() => resolvedSyncPromise({}));
+        await transport.send(ERROR_ENVELOPE);
+        expect(mockRequestExecutor).toHaveBeenCalledTimes(1);
+        // No send_error recorded for successful request
+        expect(mockRecordDroppedEventCallback).not.toHaveBeenCalled();
+      });
+    });
   });
 });