test: add middleware error test

Author: logaretm

dev-packages/e2e-tests/test-applications/nitro-3/server/middleware/test.ts

@@ -1,6 +1,10 @@
-import { defineHandler, setResponseHeader } from 'nitro/h3';
+import { defineHandler, getQuery, setResponseHeader } from 'nitro/h3';
 
 export default defineHandler(event => {
-  // Simple middleware that adds a custom header to verify it ran
   setResponseHeader(event, 'x-sentry-test-middleware', 'executed');
+
+  const query = getQuery(event);
+  if (query['middleware-error'] === '1') {
+    throw new Error('Middleware error');
+  }
 });

dev-packages/e2e-tests/test-applications/nitro-3/tests/middleware.test.ts

@@ -1,5 +1,5 @@
 import { expect, test } from '@playwright/test';
-import { waitForTransaction } from '@sentry-internal/test-utils';
+import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
 
 test('Creates middleware spans for requests', async ({ request }) => {
   const transactionEventPromise = waitForTransaction('nitro-3', event => {
@@ -18,3 +18,23 @@ test('Creates middleware spans for requests', async ({ request }) => {
   );
   expect(h3MiddlewareSpans?.length).toBeGreaterThanOrEqual(1);
 });
+
+test('Captures errors thrown in middleware with error status on span', async ({ request }) => {
+  const errorEventPromise = waitForError('nitro-3', event => {
+    return !event.type && !!event.exception?.values?.some(v => v.value === 'Middleware error');
+  });
+
+  const transactionEventPromise = waitForTransaction('nitro-3', event => {
+    return event?.transaction === 'GET /api/test-transaction' && event?.contexts?.trace?.status === 'internal_error';
+  });
+
+  await request.get('/api/test-transaction?middleware-error=1');
+
+  const errorEvent = await errorEventPromise;
+  expect(errorEvent.exception?.values?.some(v => v.value === 'Middleware error')).toBe(true);
+
+  const transactionEvent = await transactionEventPromise;
+
+  // The transaction span should have error status
+  expect(transactionEvent.contexts?.trace?.status).toBe('internal_error');
+});