Merge branch 'develop' into nh/langgraph-no-invoke-agent

Author: nicohrubec

.claude/skills/e2e/SKILL.md

@@ -0,0 +1,200 @@
+---
+name: e2e
+description: Run E2E tests for Sentry JavaScript SDK test applications
+argument-hint: <test-app-name> [--variant <variant-name>]
+---
+
+# E2E Test Runner Skill
+
+This skill runs end-to-end tests for Sentry JavaScript SDK test applications. It ensures SDK packages are built before running tests.
+
+## Input
+
+The user provides a test application name and optionally a variant:
+
+- `e2e-tests/test-applications/nextjs-app-dir` (full path)
+- `nextjs-app-dir` (just the app name)
+- `nextjs-app-dir --variant nextjs-15` (with variant)
+
+## Workflow
+
+### Step 1: Parse the Test Application Name
+
+Extract the test app name from user input:
+
+- Strip `e2e-tests/test-applications/` prefix if present
+- Extract variant flag if provided (e.g., `--variant nextjs-15`)
+- Store the clean app name (e.g., `nextjs-app-dir`)
+
+### Step 2: Determine Which Packages Need Rebuilding
+
+If the user recently edited files in `packages/*`, identify which packages were modified:
+
+```bash
+# Check which packages have uncommitted changes (including untracked files)
+git status --porcelain | grep "^[ MARC?][ MD?] packages/" | cut -d'/' -f2 | sort -u
+```
+
+For each modified package, rebuild its tarball:
+
+```bash
+cd packages/<package-name>
+yarn build && yarn build:tarball
+cd ../..
+```
+
+**Option C: User Specifies Packages**
+
+If the user says "I changed @sentry/node" or similar, rebuild just that package:
+
+```bash
+cd packages/node
+yarn build && yarn build:tarball
+cd ../..
+```
+
+### Step 3: Verify Test Application Exists
+
+Check that the test app exists:
+
+```bash
+ls -d dev-packages/e2e-tests/test-applications/<app-name>
+```
+
+If it doesn't exist, list available test apps:
+
+```bash
+ls dev-packages/e2e-tests/test-applications/
+```
+
+Ask the user which one they meant.
+
+### Step 4: Run the E2E Test
+
+Navigate to the e2e-tests directory and run the test:
+
+```bash
+cd dev-packages/e2e-tests
+yarn test:run <app-name>
+```
+
+If a variant was specified:
+
+```bash
+cd dev-packages/e2e-tests
+yarn test:run <app-name> --variant <variant-name>
+```
+
+### Step 5: Report Results
+
+After the test completes, provide a summary:
+
+**If tests passed:**
+
+```
+✅ E2E tests passed for <app-name>
+
+All tests completed successfully. Your SDK changes work correctly with this test application.
+```
+
+**If tests failed:**
+
+```
+❌ E2E tests failed for <app-name>
+
+[Include relevant error output]
+```
+
+**If package rebuild was needed:**
+
+```
+📦 Rebuilt SDK packages: <list of packages>
+🧪 Running E2E tests for <app-name>...
+```
+
+## Error Handling
+
+- **No tarballs found**: Run `yarn build && yarn build:tarball` at repository root
+- **Test app not found**: List available apps and ask user to clarify
+- **Verdaccio not running**: Tests should start Verdaccio automatically, but if issues occur, check Docker
+- **Build failures**: Fix build errors before running tests
+
+## Common Test Applications
+
+Here are frequently tested applications:
+
+- `nextjs-app-dir` - Next.js App Router
+- `nextjs-15` - Next.js 15.x
+- `react-create-hash-router` - React with React Router
+- `node-express-esm-loader` - Node.js Express with ESM
+- `sveltekit-2` - SvelteKit 2.x
+- `remix-2` - Remix 2.x
+- `nuxt-3` - Nuxt 3.x
+
+To see all available test apps:
+
+```bash
+ls dev-packages/e2e-tests/test-applications/
+```
+
+## Example Workflows
+
+### Example 1: After modifying @sentry/node
+
+```bash
+# User: "Run e2e tests for node-express-esm-loader"
+
+# Step 1: Detect recent changes to packages/node
+# Step 2: Rebuild the modified package
+cd packages/node
+yarn build && yarn build:tarball
+cd ../..
+
+# Step 3: Run the test
+cd dev-packages/e2e-tests
+yarn test:run node-express-esm-loader
+```
+
+### Example 2: First-time test run
+
+```bash
+# User: "Run e2e tests for nextjs-app-dir"
+
+# Step 1: Check for existing tarballs
+# Step 2: None found, build all packages
+yarn build && yarn build:tarball
+
+# Step 3: Run the test
+cd dev-packages/e2e-tests
+yarn test:run nextjs-app-dir
+```
+
+### Example 3: With variant
+
+```bash
+# User: "Run e2e tests for nextjs-app-dir with nextjs-15 variant"
+
+# Step 1: Rebuild if needed
+# Step 2: Run with variant
+cd dev-packages/e2e-tests
+yarn test:run nextjs-app-dir --variant nextjs-15
+```
+
+## Tips
+
+- **Always rebuild after SDK changes**: Tarballs contain the compiled SDK code
+- **Watch build output**: Build errors must be fixed before testing
+
+## Integration with Development Workflow
+
+This skill integrates with the standard SDK development workflow:
+
+1. Make changes to SDK code in `packages/*`
+2. Run `/e2e <app-name>` to test your changes
+3. Fix any test failures
+
+The skill automates the tedious parts of:
+
+- Remembering to rebuild tarballs
+- Navigating to the correct directory
+- Running tests with the right flags

.craft.yml

@@ -146,7 +146,7 @@ targets:
   # AWS Lambda Layer target
   - name: aws-lambda-layer
     includeNames: /^sentry-node-serverless-\d+.\d+.\d+(-(beta|alpha|rc)\.\d+)?\.zip$/
-    layerName: SentryNodeServerlessSDKv10
+    layerName: SentryNodeServerlessSDKv{{{major}}}
     compatibleRuntimes:
       - name: node
         versions:

.cursor/rules/sdk_development.mdc

@@ -121,6 +121,54 @@ Each package typically contains:
 - Integration tests use Playwright extensively
 - Never change the volta, yarn, or package manager setup in general unless explicitly asked for
 
+### E2E Testing
+
+E2E tests are located in `dev-packages/e2e-tests/` and verify SDK behavior in real-world framework scenarios.
+
+#### How Verdaccio Registry Works
+
+E2E tests use [Verdaccio](https://verdaccio.org/), a lightweight npm registry running in Docker. Before tests run:
+
+1. SDK packages are built and packed into tarballs (`yarn build && yarn build:tarball`)
+2. Tarballs are published to Verdaccio at `http://127.0.0.1:4873`
+3. Test applications install packages from Verdaccio instead of public npm
+
+#### The `.npmrc` Requirement
+
+Every E2E test application needs an `.npmrc` file with:
+
+```
+@sentry:registry=http://127.0.0.1:4873
+@sentry-internal:registry=http://127.0.0.1:4873
+```
+
+Without this file, pnpm installs from the public npm registry instead of Verdaccio, so your local changes won't be tested. This is a common cause of "tests pass in CI but fail locally" or vice versa.
+
+#### Running a Single E2E Test
+
+```bash
+# Build packages first
+yarn build && yarn build:tarball
+
+# Run a specific test app
+cd dev-packages/e2e-tests
+yarn test:run <app-name>
+
+# Run with a specific variant (e.g., Next.js 15)
+yarn test:run <app-name> --variant <variant-name>
+```
+
+#### Common Pitfalls and Debugging
+
+1. **Missing `.npmrc`**: Most common issue. Always verify the test app has the correct `.npmrc` file.
+
+2. **Stale tarballs**: After SDK changes, must re-run `yarn build:tarball`.
+
+3. **Debugging tips**:
+   - Check browser console logs for SDK initialization errors
+   - Use `debug: true` in Sentry config
+   - Verify installed package version: check `node_modules/@sentry/*/package.json`
+
 ### Notes for Background Tasks
 
 - Make sure to use [volta](https://volta.sh/) for development. Volta is used to manage the node, yarn and pnpm version used.

.github/workflows/auto-release.yml

@@ -15,7 +15,7 @@ jobs:
     steps:
       - name: Get auth token
         id: token
-        uses: actions/create-github-app-token@7e473efe3cb98aa54f8d4bac15400b15fad77d94 # v2.2.0
+        uses: actions/create-github-app-token@29824e69f54612133e76f7eaac726eef6c875baf # v2.2.1
         with:
           app-id: ${{ vars.SENTRY_RELEASE_BOT_CLIENT_ID }}
           private-key: ${{ secrets.SENTRY_RELEASE_BOT_PRIVATE_KEY }}

.github/workflows/build.yml

@@ -159,7 +159,7 @@ jobs:
           head: ${{ env.HEAD_COMMIT }}
 
       - name: NX cache
-        uses: actions/cache@v4
+        uses: actions/cache@v5
         # Disable cache when:
         # - on release branches
         # - when PR has `ci-skip-cache` label or on nightly builds
@@ -181,7 +181,7 @@ jobs:
         run: yarn build
 
       - name: Upload build artifacts
-        uses: actions/upload-artifact@v5
+        uses: actions/upload-artifact@v6
         with:
           name: build-output
           path: ${{ env.CACHED_BUILD_PATHS }}
@@ -386,7 +386,7 @@ jobs:
         run: yarn build:tarball
 
       - name: Archive artifacts
-        uses: actions/upload-artifact@v5
+        uses: actions/upload-artifact@v6
         with:
           name: ${{ github.sha }}
           retention-days: 90
@@ -568,9 +568,11 @@ jobs:
           - bundle_min
           - bundle_replay
           - bundle_tracing
+          - bundle_tracing_logs_metrics
           - bundle_tracing_replay
           - bundle_tracing_replay_feedback
           - bundle_tracing_replay_feedback_min
+          - bundle_tracing_replay_feedback_logs_metrics
         project:
           - chromium
         include:
@@ -629,7 +631,7 @@ jobs:
           format(' --shard={0}/{1}', matrix.shard, matrix.shards) || '' }}
 
       - name: Upload Playwright Traces
-        uses: actions/upload-artifact@v5
+        uses: actions/upload-artifact@v6
         if: failure()
         with:
           name:
@@ -692,7 +694,7 @@ jobs:
           yarn test:loader
 
       - name: Upload Playwright Traces
-        uses: actions/upload-artifact@v5
+        uses: actions/upload-artifact@v6
         if: failure()
         with:
           name: playwright-traces-job_browser_loader_tests-${{ matrix.bundle}}
@@ -881,7 +883,7 @@ jobs:
         with:
           dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
       - name: NX cache
-        uses: actions/cache/restore@v4
+        uses: actions/cache/restore@v5
         with:
           path: .nxcache
           key: nx-Linux-${{ github.ref }}-${{ env.HEAD_COMMIT }}
@@ -892,7 +894,7 @@ jobs:
         run: yarn build:tarball
 
       - name: Stores tarballs in cache
-        uses: actions/cache/save@v4
+        uses: actions/cache/save@v5
         with:
           path: ${{ github.workspace }}/packages/*/*.tgz
           key: ${{ env.BUILD_CACHE_TARBALL_KEY }}
@@ -959,7 +961,7 @@ jobs:
           dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
 
       - name: Restore tarball cache
-        uses: actions/cache/restore@v4
+        uses: actions/cache/restore@v5
         id: restore-tarball-cache
         with:
           path: ${{ github.workspace }}/packages/*/*.tgz
@@ -1009,7 +1011,7 @@ jobs:
           SENTRY_E2E_WORKSPACE_ROOT: ${{ github.workspace }}
 
       - name: Upload Playwright Traces
-        uses: actions/upload-artifact@v5
+        uses: actions/upload-artifact@v6
         if: failure()
         with:
           name: playwright-traces-job_e2e_playwright_tests-${{ matrix.test-application}}
@@ -1023,7 +1025,7 @@ jobs:
           node ./scripts/normalize-e2e-test-dump-transaction-events.js
 
       - name: Upload E2E Test Event Dumps
-        uses: actions/upload-artifact@v5
+        uses: actions/upload-artifact@v6
         if: failure()
         with:
           name: E2E Test Dump (${{ matrix.label || matrix.test-application }})
@@ -1084,7 +1086,7 @@ jobs:
           dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
 
       - name: Restore tarball cache
-        uses: actions/cache/restore@v4
+        uses: actions/cache/restore@v5
         id: restore-tarball-cache
         with:
           path: ${{ github.workspace }}/packages/*/*.tgz
@@ -1135,7 +1137,7 @@ jobs:
           node ./scripts/normalize-e2e-test-dump-transaction-events.js
 
       - name: Upload E2E Test Event Dumps
-        uses: actions/upload-artifact@v5
+        uses: actions/upload-artifact@v6
         if: failure()
         with:
           name: E2E Test Dump (${{ matrix.label || matrix.test-application }})