Remove unnecessary span.end() calls in generic RPC instrumentation

onurtemizkan · onurtemizkan · commit 854279564013 · 2026-02-20T19:16:24.000Z
diff --git a/packages/core/src/integrations/supabase.ts b/packages/core/src/integrations/supabase.ts
@@ -1084,8 +1084,6 @@ function instrumentGenericRpc(
                 if (res && typeof res === 'object' && 'error' in res && res.error && !('status' in res)) {
                   span.setStatus({ code: SPAN_STATUS_ERROR });
                 }
-
-                span.end();
               }
 
               const breadcrumb: SupabaseBreadcrumb = {
@@ -1122,7 +1120,6 @@ function instrumentGenericRpc(
 
               if (span) {
                 setHttpStatus(span, 500);
-                span.end();
               }
               throw err;
             },

Original file line number	Diff line number	Diff line change
`@@ -1084,8 +1084,6 @@ function instrumentGenericRpc(`
`1084`	`1084`	`if (res && typeof res === 'object' && 'error' in res && res.error && !('status' in res)) {`
`1085`	`1085`	`span.setStatus({ code: SPAN_STATUS_ERROR });`
`1086`	`1086`	`}`
`1087`		`-`
`1088`		`- span.end();`
`1089`	`1087`	`}`
`1090`	`1088`
`1091`	`1089`	`const breadcrumb: SupabaseBreadcrumb = {`
`@@ -1122,7 +1120,6 @@ function instrumentGenericRpc(`
`1122`	`1120`
`1123`	`1121`	`if (span) {`
`1124`	`1122`	`setHttpStatus(span, 500);`
`1125`		`- span.end();`
`1126`	`1123`	`}`
`1127`	`1124`	`throw err;`
`1128`	`1125`	`},`