Skip to content

Commit 86b4174

Browse files
committed
allow RegExp
1 parent 0efbab7 commit 86b4174

4 files changed

Lines changed: 5 additions & 6 deletions

File tree

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/ignoreMeasureSpans/init.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Sentry.init({
66
dsn: 'https://public@dsn.ingest.sentry.io/1337',
77
integrations: [
88
Sentry.browserTracingIntegration({
9-
ignoreMeasureSpans: ['measure-ignore', 'mark-i'],
9+
ignoreMeasureSpans: ['measure-ignore', /mark-i/],
1010
idleTimeout: 9000,
1111
}),
1212
],

packages/browser-utils/src/metrics/browserMetrics.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ interface AddPerformanceEntriesOptions {
315315
*
316316
* Default: []
317317
*/
318-
ignoreMeasureSpans: Array<string>;
318+
ignoreMeasureSpans: Array<string | RegExp>;
319319
}
320320

321321
/** Add performance related spans to a transaction */
@@ -449,7 +449,7 @@ export function _addMeasureSpans(
449449
startTime: number,
450450
duration: number,
451451
timeOrigin: number,
452-
ignoreMeasureSpans: Array<string>,
452+
ignoreMeasureSpans: AddPerformanceEntriesOptions['ignoreMeasureSpans'],
453453
): void {
454454
if (['mark', 'measure'].includes(entry.entryType) && stringMatchesSomePattern(entry.name, ignoreMeasureSpans)) {
455455
return;

packages/browser-utils/test/browser/browserMetrics.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,8 +173,7 @@ describe('_addMeasureSpans', () => {
173173
const duration = 356;
174174

175175
entries.forEach(e => {
176-
// full match ('measure-ignore') and partial match ('mark-i') cause the span to be ignored
177-
_addMeasureSpans(pageloadSpan, e, startTime, duration, timeOrigin, ['measure-ignore', 'mark-i']);
176+
_addMeasureSpans(pageloadSpan, e, startTime, duration, timeOrigin, ['measure-i', /mark-ign/]);
178177
});
179178

180179
expect(spans).toHaveLength(3);

packages/browser/src/tracing/browserTracingIntegration.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ export interface BrowserTracingOptions {
164164
*
165165
* Default: [] - By default, all `mark` and `measure` entries are sent as spans.
166166
*/
167-
ignoreMeasureSpans: Array<string>;
167+
ignoreMeasureSpans: Array<string | RegExp>;
168168

169169
/**
170170
* Link the currently started trace to a previous trace (e.g. a prior pageload, navigation or

0 commit comments

Comments
 (0)