Skip to content

Commit 92696ae

Browse files
committed
use direct assertion
1 parent 2155d95 commit 92696ae

4 files changed

Lines changed: 8 additions & 13 deletions

File tree

dev-packages/browser-integration-tests/suites/profiling/manualMode/test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
properFullEnvelopeRequestParser,
88
shouldSkipTracingTest,
99
} from '../../../utils/helpers';
10-
import { validateProfile, validateProfileItemHeader, validateProfilePayloadMetadata } from '../test-utils';
10+
import { validateProfile, validateProfilePayloadMetadata } from '../test-utils';
1111

1212
sentryTest(
1313
'does not send profile envelope when document-policy is not set',
@@ -48,7 +48,7 @@ sentryTest('sends profile_chunk envelopes in manual mode', async ({ page, getLoc
4848
const envelopeItemHeader = profileChunkEnvelopeItem[0];
4949
const envelopeItemPayload1 = profileChunkEnvelopeItem[1];
5050

51-
validateProfileItemHeader(envelopeItemHeader);
51+
expect(envelopeItemHeader).toEqual({ type: 'profile_chunk', platform: 'javascript' });
5252
expect(envelopeItemPayload1.profile).toBeDefined();
5353

5454
const profilerId1 = envelopeItemPayload1.profiler_id;
@@ -71,7 +71,7 @@ sentryTest('sends profile_chunk envelopes in manual mode', async ({ page, getLoc
7171
const envelopeItemHeader2 = profileChunkEnvelopeItem2[0];
7272
const envelopeItemPayload2 = profileChunkEnvelopeItem2[1];
7373

74-
validateProfileItemHeader(envelopeItemHeader2);
74+
expect(envelopeItemHeader2).toEqual({ type: 'profile_chunk', platform: 'javascript' });
7575
expect(envelopeItemPayload2.profile).toBeDefined();
7676

7777
expect(envelopeItemPayload2.profiler_id).toBe(profilerId1); // same profiler id for the whole session

dev-packages/browser-integration-tests/suites/profiling/test-utils.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,6 @@ interface ValidateProfileOptions {
77
isChunkFormat?: boolean;
88
}
99

10-
export function validateProfileItemHeader(header: Record<string, unknown>): void {
11-
expect(header).toHaveProperty('type', 'profile_chunk');
12-
expect(header).toHaveProperty('platform', 'javascript');
13-
}
14-
1510
/**
1611
* Validates the metadata of a profile chunk envelope.
1712
* https://develop.sentry.dev/sdk/telemetry/profiles/sample-format-v2/

dev-packages/browser-integration-tests/suites/profiling/traceLifecycleMode_multiple-chunks/test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
properFullEnvelopeRequestParser,
88
shouldSkipTracingTest,
99
} from '../../../utils/helpers';
10-
import { validateProfile, validateProfileItemHeader, validateProfilePayloadMetadata } from '../test-utils';
10+
import { validateProfile, validateProfilePayloadMetadata } from '../test-utils';
1111

1212
sentryTest(
1313
'does not send profile envelope when document-policy is not set',
@@ -51,7 +51,7 @@ sentryTest(
5151
const envelopeItemHeader = profileChunkEnvelopeItem[0];
5252
const envelopeItemPayload1 = profileChunkEnvelopeItem[1];
5353

54-
validateProfileItemHeader(envelopeItemHeader);
54+
expect(envelopeItemHeader).toEqual({ type: 'profile_chunk', platform: 'javascript' });
5555
expect(envelopeItemPayload1.profile).toBeDefined();
5656

5757
validateProfilePayloadMetadata(envelopeItemPayload1);
@@ -77,7 +77,7 @@ sentryTest(
7777
const envelopeItemHeader2 = profileChunkEnvelopeItem2[0];
7878
const envelopeItemPayload2 = profileChunkEnvelopeItem2[1];
7979

80-
validateProfileItemHeader(envelopeItemHeader2);
80+
expect(envelopeItemHeader2).toEqual({ type: 'profile_chunk', platform: 'javascript' });
8181
expect(envelopeItemPayload2.profile).toBeDefined();
8282

8383
validateProfilePayloadMetadata(envelopeItemPayload2);

dev-packages/browser-integration-tests/suites/profiling/traceLifecycleMode_overlapping-spans/test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
shouldSkipTracingTest,
99
waitForTransactionRequestOnUrl,
1010
} from '../../../utils/helpers';
11-
import { validateProfile, validateProfileItemHeader, validateProfilePayloadMetadata } from '../test-utils';
11+
import { validateProfile, validateProfilePayloadMetadata } from '../test-utils';
1212

1313
sentryTest(
1414
'does not send profile envelope when document-policy is not set',
@@ -52,7 +52,7 @@ sentryTest(
5252
const envelopeItemHeader = profileChunkEnvelopeItem[0];
5353
const envelopeItemPayload = profileChunkEnvelopeItem[1];
5454

55-
validateProfileItemHeader(envelopeItemHeader);
55+
expect(envelopeItemHeader).toEqual({ type: 'profile_chunk', platform: 'javascript' });
5656
expect(envelopeItemPayload.profile).toBeDefined();
5757

5858
validateProfilePayloadMetadata(envelopeItemPayload);

0 commit comments

Comments
 (0)