fixup! fixup! fixup! fixup! fixup! feat(core): split exports by browser/server for bundle size

Author: isaacs

dev-packages/rollup-utils/npmHelpers.mjs

@@ -100,12 +100,17 @@ export function makeBaseNPMConfig(options = {}) {
     plugins: [nodeResolvePlugin, sucrasePlugin, debugBuildStatementReplacePlugin, rrwebBuildPlugin, cleanupPlugin],
 
     // don't include imported modules from outside the package in the final output
-    external: [
-      ...builtinModules.filter(m => !bundledBuiltins.includes(m)),
-      ...Object.keys(packageDotJSON.dependencies || {}),
-      ...Object.keys(packageDotJSON.peerDependencies || {}),
-      ...Object.keys(packageDotJSON.optionalDependencies || {}),
-    ],
+    // also treat subpath exports (e.g. `@sentry/core/browser`) as external
+    external: id => {
+      const deps = [
+        ...builtinModules.filter(m => !bundledBuiltins.includes(m)),
+        ...Object.keys(packageDotJSON.dependencies || {}),
+        ...Object.keys(packageDotJSON.peerDependencies || {}),
+        ...Object.keys(packageDotJSON.optionalDependencies || {}),
+      ];
+      // treat subpath exports as external if the package is external
+      return deps.some(dep => id === dep || id.startsWith(`${dep}/`));
+    },
   };
 
   return deepMerge(defaultBaseConfig, packageSpecificConfig, {