Skip to content

Commit 99da0a7

Browse files
logaretmclaude
andcommitted
chore: address PR review feedback for nitro package
- Update LICENSE copyright year to 2026 - Expand peerDependencies range to cover nitro prereleases - Bump nitro devDependency to latest beta - Add beta notice to README - Improve README wording (section title, Vite capitalization, --import mention) - Point .craft.yml docs URL to package README until docs page exists - Include 'node' in applySdkMetadata packages list for consistency Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 843a50a commit 99da0a7

File tree

6 files changed

+196
-74
lines changed

6 files changed

+196
-74
lines changed

.craft.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,5 +263,5 @@ targets:
263263
name: 'Sentry Nitro SDK'
264264
sdkName: 'sentry.javascript.nitro'
265265
packageUrl: 'https://www.npmjs.com/package/@sentry/nitro'
266-
mainDocsUrl: 'https://docs.sentry.io/platforms/javascript/guides/nitro/'
266+
mainDocsUrl: 'https://github.com/getsentry/sentry-javascript/tree/master/packages/nitro'
267267
onlyIfPresent: /^sentry-nitro-\d.*\.tgz$/

packages/nitro/LICENSE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
MIT License
22

3-
Copyright (c) 2023 Functional Software, Inc. dba Sentry
3+
Copyright (c) 2026 Functional Software, Inc. dba Sentry
44

55
Permission is hereby granted, free of charge, to any person obtaining a copy of
66
this software and associated documentation files (the "Software"), to deal in

packages/nitro/README.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
</a>
55
</p>
66

7+
> NOTICE: This package is in beta state and may be subject to breaking changes.
8+
79
# Official Sentry SDK for Nitro
810

911
[![npm version](https://img.shields.io/npm/v/@sentry/nitro.svg)](https://www.npmjs.com/package/@sentry/nitro)
@@ -44,7 +46,7 @@ This package is a wrapper around `@sentry/node` with added instrumentation for N
4446
pnpm add @sentry/nitro
4547
```
4648

47-
### 2. Nitro Config Setup
49+
### 2. Build-Time Nitro Config Setup
4850

4951
1. Import `withSentryConfig` from `@sentry/nitro` and call it with your Nitro config.
5052

@@ -67,7 +69,7 @@ export default withSentryConfig(config, {
6769

6870
#### In `vite.config.ts`
6971

70-
If you are using nitro as a Vite plugin, you can import `withSentryConfig` from `@sentry/nitro` and call it with your Nitro config.
72+
If you are using Nitro as a Vite plugin, you can import `withSentryConfig` from `@sentry/nitro` and call it with your Nitro config.
7173

7274
```ts
7375
import { defineConfig } from 'vite';
@@ -100,7 +102,7 @@ Sentry.init({
100102
});
101103
```
102104

103-
Then use `NODE_OPTIONS` to load the instrumentation before your app code:
105+
Then use `--import` in `NODE_OPTIONS` to load the instrumentation before your app code:
104106

105107
```bash
106108
NODE_OPTIONS='--import ./instrument.mjs' npx nitro dev

packages/nitro/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,14 @@
3535
"access": "public"
3636
},
3737
"peerDependencies": {
38-
"nitro": ">=3.0.260311-beta"
38+
"nitro": ">=3.0.0-0 <4.0.0 || 3.0.260311-beta || 3.0.260415-beta"
3939
},
4040
"dependencies": {
4141
"@sentry/core": "10.48.0",
4242
"@sentry/node": "10.48.0"
4343
},
4444
"devDependencies": {
45-
"nitro": "^3.0.260311-beta"
45+
"nitro": "^3.0.260415-beta"
4646
},
4747
"scripts": {
4848
"build": "run-p build:transpile build:types",

packages/nitro/src/sdk.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export function init(options: NodeOptions | undefined = {}): NodeClient | undefi
1212
...options,
1313
};
1414

15-
applySdkMetadata(opts, 'nitro');
15+
applySdkMetadata(opts, 'nitro', ['nitro', 'node']);
1616

1717
const client = nodeInit(opts);
1818

0 commit comments

Comments
 (0)