Don't assume previous shouldSendCallback exists in RN plugin (fixes #692) (#694)

benvinegar · web-flow · commit bef9fa75bd29 · 2016-08-18T14:10:51.000-07:00
diff --git a/plugins/react-native.js b/plugins/react-native.js
@@ -86,7 +86,8 @@ function reactNativePlugin(Raven, options) {
 
     Raven.setShouldSendCallback(function(data, originalCallback) {
         if (!(FATAL_ERROR_KEY in data)) {
-            return originalCallback.call(this, data);
+            // not a fatal (will not crash runtime), continue as planned
+            return originalCallback ? originalCallback.call(this, data) : true;
         }
 
         var origError = data[FATAL_ERROR_KEY];

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,8 @@ function reactNativePlugin(Raven, options) {`
`86`	`86`
`87`	`87`	`Raven.setShouldSendCallback(function(data, originalCallback) {`
`88`	`88`	`if (!(FATAL_ERROR_KEY in data)) {`
`89`		`- return originalCallback.call(this, data);`
	`89`	`+ // not a fatal (will not crash runtime), continue as planned`
	`90`	`+ return originalCallback ? originalCallback.call(this, data) : true;`
`90`	`91`	`}`
`91`	`92`
`92`	`93`	`var origError = data[FATAL_ERROR_KEY];`