Skip to content

Commit bfb6d17

Browse files
mydeaclaude
andcommitted
fix(ci): Remove container from E2E jobs — they need host Docker access
E2E tests use Docker-in-Docker (Verdaccio registry) which doesn't work inside a GHA container due to network isolation. On develop these jobs run directly on the host. Only browser Playwright, loader, and Remix tests need the Playwright container image. Revert registrySetup.ts path conversion and temp directory changes for E2E jobs since they now run on the host again. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent befd626 commit bfb6d17

2 files changed

Lines changed: 12 additions & 26 deletions

File tree

.github/workflows/build.yml

Lines changed: 9 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -922,15 +922,8 @@ jobs:
922922
# See: https://github.com/actions/runner/issues/2205
923923
if:
924924
always() && needs.job_e2e_prepare.result == 'success' && needs.job_e2e_prepare.outputs.matrix != '{"include":[]}'
925-
&& needs.job_playwright_image.result == 'success'
926-
needs: [job_get_metadata, job_build, job_e2e_prepare, job_playwright_image]
925+
needs: [job_get_metadata, job_build, job_e2e_prepare]
927926
runs-on: ubuntu-24.04
928-
container:
929-
image: ${{ needs.job_playwright_image.outputs.image }}
930-
credentials:
931-
username: ${{ github.actor }}
932-
password: ${{ secrets.GITHUB_TOKEN }}
933-
options: --ipc=host --user root
934927
timeout-minutes: 15
935928
env:
936929
# We just use a dummy DSN here, only send to the tunnel anyhow
@@ -996,18 +989,18 @@ jobs:
996989
working-directory: dev-packages/e2e-tests
997990

998991
- name: Copy to temp
999-
run: yarn ci:copy-to-temp ./test-applications/${{ matrix.test-application }} ../tmp-test-application
992+
run: yarn ci:copy-to-temp ./test-applications/${{ matrix.test-application }} ${{ runner.temp }}/test-application
1000993
working-directory: dev-packages/e2e-tests
1001994

1002995
- name: Build E2E app
1003-
working-directory: dev-packages/tmp-test-application
996+
working-directory: ${{ runner.temp }}/test-application
1004997
timeout-minutes: 7
1005998
run: ${{ matrix.build-command || 'pnpm test:build' }}
1006999
env:
10071000
SENTRY_E2E_WORKSPACE_ROOT: ${{ github.workspace }}
10081001

10091002
- name: Run E2E test
1010-
working-directory: dev-packages/tmp-test-application
1003+
working-directory: ${{ runner.temp }}/test-application
10111004
timeout-minutes: 10
10121005
run: ${{ matrix.assert-command || 'pnpm test:assert' }}
10131006
env:
@@ -1046,16 +1039,9 @@ jobs:
10461039
if:
10471040
always() && needs.job_get_metadata.outputs.is_release != 'true' && needs.job_e2e_prepare.result == 'success' &&
10481041
needs.job_e2e_prepare.outputs.matrix-optional != '{"include":[]}' && (github.event_name != 'pull_request' ||
1049-
github.event.pull_request.head.repo.full_name == github.repository) && github.actor != 'dependabot[bot]' &&
1050-
needs.job_playwright_image.result == 'success'
1051-
needs: [job_get_metadata, job_build, job_e2e_prepare, job_playwright_image]
1042+
github.event.pull_request.head.repo.full_name == github.repository) && github.actor != 'dependabot[bot]'
1043+
needs: [job_get_metadata, job_build, job_e2e_prepare]
10521044
runs-on: ubuntu-24.04
1053-
container:
1054-
image: ${{ needs.job_playwright_image.outputs.image }}
1055-
credentials:
1056-
username: ${{ github.actor }}
1057-
password: ${{ secrets.GITHUB_TOKEN }}
1058-
options: --ipc=host --user root
10591045
timeout-minutes: 15
10601046
env:
10611047
E2E_TEST_AUTH_TOKEN: ${{ secrets.E2E_TEST_AUTH_TOKEN }}
@@ -1108,16 +1094,16 @@ jobs:
11081094
working-directory: dev-packages/e2e-tests
11091095

11101096
- name: Copy to temp
1111-
run: yarn ci:copy-to-temp ./test-applications/${{ matrix.test-application }} ../tmp-test-application
1097+
run: yarn ci:copy-to-temp ./test-applications/${{ matrix.test-application }} ${{ runner.temp }}/test-application
11121098
working-directory: dev-packages/e2e-tests
11131099

11141100
- name: Build E2E app
1115-
working-directory: dev-packages/tmp-test-application
1101+
working-directory: ${{ runner.temp }}/test-application
11161102
timeout-minutes: 7
11171103
run: ${{ matrix.build-command || 'pnpm test:build' }}
11181104

11191105
- name: Run E2E test
1120-
working-directory: dev-packages/tmp-test-application
1106+
working-directory: ${{ runner.temp }}/test-application
11211107
timeout-minutes: 10
11221108
run: ${{ matrix.assert-command || 'pnpm test:assert' }}
11231109

.github/workflows/canary.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -173,16 +173,16 @@ jobs:
173173
working-directory: dev-packages/e2e-tests
174174

175175
- name: Copy to temp
176-
run: yarn ci:copy-to-temp ./test-applications/${{ matrix.test-application }} ../tmp-test-application
176+
run: yarn ci:copy-to-temp ./test-applications/${{ matrix.test-application }} ${{ runner.temp }}/test-application
177177
working-directory: dev-packages/e2e-tests
178178

179179
- name: Build E2E app
180-
working-directory: dev-packages/tmp-test-application
180+
working-directory: ${{ runner.temp }}/test-application
181181
timeout-minutes: 7
182182
run: yarn ${{ matrix.build-command }}
183183

184184
- name: Run E2E test
185-
working-directory: dev-packages/tmp-test-application
185+
working-directory: ${{ runner.temp }}/test-application
186186
timeout-minutes: 15
187187
run: yarn test:assert
188188

0 commit comments

Comments
 (0)