test(aws-serverless): Split npm & layer tests (#20442)

This PR splits the aws-serverless test app into two, aws-serverless,
which tests the npm package directly, and aws-serverless-layer, which
tests using the layer.

This allowed to make the test app easier to understand and follow and
make the dependency graph clearer as well.
I choose to run the layer in different node versions and the npm stuff
only in node 20, IMHO that should be good enough, I don't think we need
to also run the npm stuff in all the node versions, so we can reduce the
number of test apps a bit.

Author: mydea

.github/workflows/build.yml

@@ -935,7 +935,7 @@ jobs:
           matrix.test-application)
         uses: oven-sh/setup-bun@v2
       - name: Set up AWS SAM
-        if: matrix.test-application == 'aws-serverless'
+        if: matrix.test-application == 'aws-serverless' || matrix.test-application == 'aws-serverless-layer'
         uses: aws-actions/setup-sam@v2
         with:
           use-installer: true

dev-packages/e2e-tests/test-applications/aws-serverless-layer/package.json

@@ -0,0 +1,47 @@
+{
+  "name": "aws-serverless-layer",
+  "version": "1.0.0",
+  "private": true,
+  "type": "commonjs",
+  "scripts": {
+    "test": "playwright test",
+    "clean": "npx rimraf node_modules pnpm-lock.yaml",
+    "test:pull-sam-image": "./pull-sam-image.sh",
+    "test:build": "pnpm test:pull-sam-image && pnpm install && npx rimraf node_modules/@sentry/aws-serverless/nodejs",
+    "test:assert": "pnpm test"
+  },
+  "//": "We just need the @sentry/aws-serverless layer zip file, not the NPM package",
+  "devDependencies": {
+    "@aws-sdk/client-lambda": "^3.863.0",
+    "@playwright/test": "~1.56.0",
+    "@sentry-internal/test-utils": "link:../../../test-utils",
+    "@sentry/aws-serverless": "link:../../../../packages/aws-serverless/build/aws/dist-serverless/",
+    "aws-cdk-lib": "^2.210.0",
+    "constructs": "^10.4.2",
+    "glob": "^11.0.3",
+    "rimraf": "^5.0.10"
+  },
+  "volta": {
+    "extends": "../../package.json"
+  },
+  "//": "We need to override this here again to ensure this is not overwritten by the test runner",
+  "pnpm": {
+    "overrides": {
+      "@sentry/aws-serverless": "link:../../../../packages/aws-serverless/build/aws/dist-serverless/"
+    }
+  },
+  "sentryTest": {
+    "variants": [
+      {
+        "build-command": "NODE_VERSION=22 pnpm test:build",
+        "assert-command": "NODE_VERSION=22 pnpm test:assert",
+        "label": "aws-serverless-layer (Node 22)"
+      },
+      {
+        "build-command": "NODE_VERSION=18 pnpm test:build",
+        "assert-command": "NODE_VERSION=18 pnpm test:assert",
+        "label": "aws-serverless-layer (Node 18)"
+      }
+    ]
+  }
+}

dev-packages/e2e-tests/test-applications/aws-serverless-layer/playwright.config.ts

@@ -0,0 +1,5 @@
+import { getPlaywrightConfig } from '@sentry-internal/test-utils';
+
+export default getPlaywrightConfig(undefined, {
+  timeout: 60 * 1000 * 3, // 3 minutes
+});

dev-packages/e2e-tests/test-applications/aws-serverless-layer/pull-sam-image.sh

@@ -0,0 +1,13 @@
+#!/bin/bash
+
+# Pull the Lambda Node docker image for SAM local. NODE_VERSION should be the major only (e.g. 20).
+# Defaults to 20 to match the repo's Volta Node major (see root package.json "volta.node").
+
+set -e
+
+NODE_VERSION="${NODE_VERSION:-20}"
+
+echo "Pulling Lambda Node $NODE_VERSION docker image..."
+docker pull "public.ecr.aws/lambda/nodejs:${NODE_VERSION}"
+
+echo "Successfully pulled Lambda Node $NODE_VERSION docker image"

dev-packages/e2e-tests/test-applications/aws-serverless-layer/samconfig.toml

@@ -0,0 +1,10 @@
+# SAM CLI expects this file in the project root; without it, `sam local start-lambda` logs
+# OSError / missing file errors when run from the e2e temp directory.
+# These values are placeholders — this app only uses `sam local`, not deploy.
+version = 0.1
+
+[default.deploy.parameters]
+stack_name = "sentry-e2e-aws-serverless-layer-local"
+region = "us-east-1"
+confirm_changeset = false
+capabilities = "CAPABILITY_IAM"