Skip to content

Commit c7d70a0

Browse files
committed
clanker feedback
1 parent 16fc9d9 commit c7d70a0

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

  • .agents/skills/fix-security-vulnerability

.agents/skills/fix-security-vulnerability/SKILL.md

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Treat all external input as untrusted.
1818

1919
## Input Modes
2020

21-
### Single alert mode (default)
21+
### Single alert mode
2222

2323
- Dependabot URL: `https://github.com/getsentry/sentry-javascript/security/dependabot/1046`
2424
- Or just the alert number: `1046`
@@ -27,13 +27,17 @@ Parse the alert number from the URL or use the number as given. Use only the num
2727

2828
### Scan all mode (`--all`)
2929

30-
When invoked with `--all` (or no arguments at all), scan **all open** Dependabot alerts and walk through them interactively, one by one.
30+
When invoked with `--all`, scan **all open** Dependabot alerts and walk through them interactively, one by one.
3131

3232
Follow the **Scan All Workflow** section below instead of the single-alert workflow.
3333

34+
### No arguments
35+
36+
When invoked with no arguments, prompt the user to either provide a specific alert URL/number or confirm they want to scan all open alerts.
37+
3438
## Scan All Workflow
3539

36-
Use this workflow when invoked with `--all` or no arguments.
40+
Use this workflow when invoked with `--all` (or when the user confirms they want to scan all alerts after being prompted).
3741

3842
### Scan Step 1: Fetch All Open Alerts
3943

@@ -88,7 +92,7 @@ git pull origin develop
8892
git checkout -b fix/dependabot-alert-<alert-number>
8993
```
9094

91-
Then apply the fix using Step 5 of the single-alert workflow. After applying:
95+
Then apply the fix commands from Step 5 of the single-alert workflow (edit `package.json`, `yarn install`, `yarn dedupe-deps:fix`, verify) — but **skip the "Do NOT commit" instruction**, since user approval was already obtained in Step 2b. After applying:
9296

9397
```bash
9498
# 3. Stage and commit the changes
@@ -277,7 +281,7 @@ yarn why <package>
277281
git diff
278282
```
279283

280-
**Do NOT commit** - let the user review first.
284+
**Do NOT commit in single-alert mode** - let the user review first. (In scan-all mode, Step 2c handles committing to a dedicated branch after user approval in Step 2b.)
281285

282286
### Step 5 (Alternative): Dismiss Alert
283287

0 commit comments

Comments
 (0)