Skip to content

Commit c993616

Browse files
committed
fix(tanstackstart-react): treat empty tunnel path as omitted
Made-with: Cursor
1 parent e68a210 commit c993616

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

packages/tanstackstart-react/src/vite/tunnelRoute.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ function normalizeTunnelRouteOptions(options: TunnelRouteOptions): NormalizedTun
7979
validateStaticPath(path);
8080
}
8181

82-
return { resolvedPath: resolveTunnelRoute(path ?? true), allowedDsns };
82+
return { resolvedPath: resolveTunnelRoute(path || true), allowedDsns };
8383
}
8484

8585
function hasRouteConflict(source: string, resolvedTunnelRoute: string): boolean {

packages/tanstackstart-react/test/vite/tunnelRoute.test.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,4 +127,13 @@ describe('tunnelRoute vite plugin', () => {
127127
expect(virtualRouteModule).toContain('createFileRoute("/monitor")');
128128
expect(virtualRouteModule).toContain('createSentryTunnelRoute({})');
129129
});
130+
131+
it('treats an empty string `path` like omitted and uses a generated tunnel route', () => {
132+
const plugin = makeTunnelRoutePlugin({ path: '' });
133+
134+
const defined = plugin.config && plugin.config();
135+
const serialized = defined?.define?.__SENTRY_TANSTACKSTART_TUNNEL_ROUTE__;
136+
expect(typeof serialized).toBe('string');
137+
expect(serialized).toMatch(/^"\/[a-z0-9]{8}"$/);
138+
});
130139
});

0 commit comments

Comments
 (0)