Skip to content

Commit cc80587

Browse files
committed
address cursor comments
1 parent a057663 commit cc80587

File tree

3 files changed

+13
-14
lines changed

3 files changed

+13
-14
lines changed

dev-packages/e2e-tests/test-applications/ember-classic/app/app.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,12 @@ Sentry.init({
1010
tracesSampleRate: 1,
1111
replaysSessionSampleRate: 1,
1212
replaysOnErrorSampleRate: 1,
13+
browserTracingOptions: {
14+
_experiments: {
15+
// Long-task spans are noisy in e2e and make assertions flaky.
16+
enableLongTask: false,
17+
},
18+
},
1319
tracePropagationTargets: ['localhost', 'doesntexist.example'],
1420
tunnel: `http://localhost:3031/`, // proxy server
1521
});

dev-packages/e2e-tests/test-applications/ember-embroider/app/app.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,12 @@ Sentry.init({
99
tracesSampleRate: 1,
1010
replaysSessionSampleRate: 1,
1111
replaysOnErrorSampleRate: 1,
12+
browserTracingOptions: {
13+
_experiments: {
14+
// Long-task spans are noisy in e2e and make assertions flaky.
15+
enableLongTask: false,
16+
},
17+
},
1218
tracePropagationTargets: ['localhost', 'doesntexist.example'],
1319
tunnel: `http://localhost:3031/`, // proxy server
1420
});

packages/ember/tests/unit/instrument-router-location-test.ts

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { setupTest } from 'ember-qunit';
22
import { module, test } from 'qunit';
33
import { setupSentryTest } from '../helpers/setup-sentry.ts';
4+
import { getLocationURL } from '../../src/utils/ember/router.ts';
45

56
import type { SentryTestContext } from '../helpers/setup-sentry.ts';
67

@@ -11,20 +12,6 @@ interface Location {
1112
rootURL: string;
1213
}
1314

14-
function getLocationURL(location: Location): string {
15-
if (!location?.getURL || !location?.formatURL) {
16-
return '';
17-
}
18-
19-
const url = location.formatURL(location.getURL());
20-
21-
if (location.implementation === 'hash' || url.startsWith('#')) {
22-
return `${location.rootURL}${url}`;
23-
}
24-
25-
return url;
26-
}
27-
2815
module('Unit | Utility | instrument-router-location', function (hooks) {
2916
setupTest(hooks);
3017
setupSentryTest(hooks);

0 commit comments

Comments
 (0)