Skip to content

Commit d425cff

Browse files
committed
feat: use vite mode for better test coverage
1 parent 3b8dc3d commit d425cff

15 files changed

Lines changed: 77 additions & 26 deletions

File tree

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<!doctype html>
2+
<html lang="en">
3+
<head>
4+
<meta charset="UTF-8" />
5+
<title>Nitro E2E Test</title>
6+
</head>
7+
<body>
8+
<h1>Nitro E2E Test App</h1>
9+
<script type="module" src="/src/main.ts"></script>
10+
</body>
11+
</html>

dev-packages/e2e-tests/test-applications/nitro-3/nitro.config.ts

Lines changed: 0 additions & 8 deletions
This file was deleted.

dev-packages/e2e-tests/test-applications/nitro-3/package.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,15 @@
44
"private": true,
55
"type": "module",
66
"scripts": {
7-
"build": "nitro build",
8-
"start": "PORT=3030 NODE_OPTIONS='--import ./instrument.mjs' srvx --prod .output/",
7+
"build": "vite build",
8+
"start": "PORT=3030 NODE_OPTIONS='--import ./instrument.mjs' node .output/server/index.mjs",
99
"clean": "npx rimraf node_modules pnpm-lock.yaml .output",
1010
"test": "playwright test",
1111
"test:build": "pnpm install && pnpm build",
1212
"test:assert": "pnpm test"
1313
},
1414
"dependencies": {
15+
"@sentry/browser": "latest || *",
1516
"@sentry/nitro": "latest || *"
1617
},
1718
"devDependencies": {
@@ -20,7 +21,7 @@
2021
"@sentry/core": "latest || *",
2122
"nitro": "https://pkg.pr.new/nitrojs/nitro@4001",
2223
"rolldown": "latest",
23-
"srvx": "^0.11.2"
24+
"vite": "latest"
2425
},
2526
"volta": {
2627
"extends": "../../package.json"

dev-packages/e2e-tests/test-applications/nitro-3/routes/index.ts renamed to dev-packages/e2e-tests/test-applications/nitro-3/server/api/index.ts

File renamed without changes.

dev-packages/e2e-tests/test-applications/nitro-3/routes/test-error.ts renamed to dev-packages/e2e-tests/test-applications/nitro-3/server/api/test-error.ts

File renamed without changes.

dev-packages/e2e-tests/test-applications/nitro-3/routes/test-isolation/[id].ts renamed to dev-packages/e2e-tests/test-applications/nitro-3/server/api/test-isolation/[id].ts

File renamed without changes.

dev-packages/e2e-tests/test-applications/nitro-3/routes/test-param/[id].ts renamed to dev-packages/e2e-tests/test-applications/nitro-3/server/api/test-param/[id].ts

File renamed without changes.

dev-packages/e2e-tests/test-applications/nitro-3/routes/test-transaction.ts renamed to dev-packages/e2e-tests/test-applications/nitro-3/server/api/test-transaction.ts

File renamed without changes.
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
import * as Sentry from '@sentry/browser';
2+
3+
// Let's us test trace propagation
4+
Sentry.init({
5+
environment: 'qa',
6+
dsn: 'https://public@dsn.ingest.sentry.io/1337',
7+
tunnel: 'http://localhost:3031/', // proxy server
8+
integrations: [Sentry.browserTracingIntegration()],
9+
tracesSampleRate: 1.0,
10+
});

dev-packages/e2e-tests/test-applications/nitro-3/tests/errors.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ test('Sends an error event to Sentry', async ({ request }) => {
66
return !event.type && !!event.exception?.values?.some(v => v.value === 'This is a test error');
77
});
88

9-
await request.get('/test-error');
9+
await request.get('/api/test-error');
1010

1111
const errorEvent = await errorEventPromise;
1212

@@ -39,7 +39,7 @@ test('Does not send 404 errors to Sentry', async ({ request }) => {
3939
return false;
4040
});
4141

42-
await request.get('/non-existent-route');
42+
await request.get('/api/non-existent-route');
4343

4444
expect(errorReceived).toBe(false);
4545
});

0 commit comments

Comments
 (0)