Commit ed0a0fa
authored
fix(feedback): Fix cases where the outline of inputs were wrong (#18647)
The integration was using `"colorScheme: "dark"` we include css only
dark mode. But some properties, like `outline` were not specified, the
system does a good job by default. However, adding `color-scheme: only
light` into the css meant that the light-mode outlines were used in all
cases, even when we asked for dark mode.
This changes things so that we have the correct values for
`color-scheme` if a specific value is picked. This ensures that the
`outline` and `:focus` colors set by the system are correct in all
cases.
**Test Plan**
I tested with my system set to each of: light, dark, automatic And then
with the integration setting set to each of: `colorScheme: 'light'`,
`colorScheme: 'dark'` and `colorScheme: 'system'`. To test i just opened
up the feedback widget and clicked to focus an input box.
**Screenshots**
| Before | After |
| --- | --- |
| <img width="443" height="199" alt="SCR-20251230-pleg"
src="https://github.com/user-attachments/assets/ade46ef2-16c0-4de8-b630-6ac0cf66f440"
/> | <img width="466" height="275" alt="SCR-20251230-plch"
src="https://github.com/user-attachments/assets/a6ddbcbe-9d1b-4515-9833-84c62f0e6ed9"
/>1 parent 4aa907e commit ed0a0fa
1 file changed
+3
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
| 74 | + | |
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
| 86 | + | |
| 87 | + | |
86 | 88 | | |
87 | 89 | | |
88 | 90 | | |
89 | 91 | | |
90 | 92 | | |
91 | | - | |
92 | 93 | | |
93 | 94 | | |
94 | 95 | | |
| |||
0 commit comments