.

Author: nicohrubec

packages/core/src/utils/should-ignore-span.ts

@@ -28,7 +28,8 @@ export function shouldIgnoreSpan(
       continue;
     }
 
-    if (!pattern.name && !pattern.op && !pattern.attributes) {
+    const hasAttributes = !!pattern.attributes && Object.keys(pattern.attributes).length > 0;
+    if (!pattern.name && !pattern.op && !hasAttributes) {
       continue;
     }
 

packages/core/test/lib/utils/should-ignore-span.test.ts

@@ -134,6 +134,11 @@ describe('shouldIgnoreSpan', () => {
       expect(shouldIgnoreSpan(span, [{ attributes: { 'missing.key': 'x' } }])).toBe(false);
     });
 
+    it('does not match a filter with an empty attributes object', () => {
+      const span = { description: 'foo', op: 'bar', attributes: { x: 1 } };
+      expect(shouldIgnoreSpan(span, [{ attributes: {} }])).toBe(false);
+    });
+
     it('requires every attribute entry to match', () => {
       const span = { description: 'span', op: 'op', attributes: { a: 1, b: 2 } };
       expect(shouldIgnoreSpan(span, [{ attributes: { a: 1, b: 2 } }])).toBe(true);