feat(feedback)!: always reject sendFeedback with an Error

Previously, sendFeedback's async rejection paths (timeout, 403, generic
transport error) rejected with plain strings, while the sync-throw paths
used Error instances. Unify on Error for all paths so consumers can rely
on a consistent rejection shape.

BREAKING CHANGE: sendFeedback now always rejects with an Error whose
.message is the error code (ERROR_TIMEOUT, ERROR_FORBIDDEN, or
ERROR_GENERIC). Previously these paths rejected with the raw string.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: logaretm

packages/feedback/src/core/sendFeedback.ts

@@ -8,7 +8,7 @@ import type {
 } from '@sentry/core';
 import { captureFeedback, getClient, getCurrentScope, getLocationHref } from '@sentry/core';
 import { FEEDBACK_API_SOURCE } from '../constants';
-import { createFeedbackError, resolveFeedbackErrorMessage } from '../util/createFeedbackError';
+import { createFeedbackError } from '../util/createFeedbackError';
 
 /**
  * Public API to send a Feedback item to Sentry
@@ -47,7 +47,7 @@ export const sendFeedback: SendFeedback = (
     // After 30s, we want to clear anyhow
     const timeout = setTimeout(() => {
       cleanup();
-      reject(resolveFeedbackErrorMessage('ERROR_TIMEOUT', errorMessages));
+      reject(createFeedbackError('ERROR_TIMEOUT', errorMessages));
     }, 30_000);
 
     const cleanup = client.on('afterSendEvent', (event: Event, response: TransportMakeRequestResponse) => {
@@ -64,10 +64,10 @@ export const sendFeedback: SendFeedback = (
       }
 
       if (response?.statusCode === 403) {
-        return reject(resolveFeedbackErrorMessage('ERROR_FORBIDDEN', errorMessages));
+        return reject(createFeedbackError('ERROR_FORBIDDEN', errorMessages));
       }
 
-      return reject(resolveFeedbackErrorMessage('ERROR_GENERIC', errorMessages));
+      return reject(createFeedbackError('ERROR_GENERIC', errorMessages));
     });
   });
 };

packages/feedback/src/modal/components/Form.tsx

@@ -131,7 +131,7 @@ export function Form({
           onSubmitSuccess(data, eventId);
         } catch (error) {
           DEBUG_BUILD && debug.error(error);
-          const err = error instanceof Error ? error : new Error(String(error));
+          const err = error as Error;
           setError(err.message);
           onSubmitError(err);
         }

packages/feedback/test/core/sendFeedback.test.ts

@@ -290,7 +290,7 @@ describe('sendFeedback', () => {
 
     await expect(
       sendFeedback({ message: 'mi' }, { errorMessages: { ERROR_FORBIDDEN: 'custom forbidden text' } }),
-    ).rejects.toMatch('custom forbidden text');
+    ).rejects.toThrow('custom forbidden text');
   });
 
   it('falls back to default messages for codes not in errorMessages', async () => {
@@ -319,7 +319,7 @@ describe('sendFeedback', () => {
         email: 're@example.org',
         message: 'mi',
       }),
-    ).rejects.toMatch(
+    ).rejects.toThrow(
       'Unable to send feedback. This could be because of network issues, or because you are using an ad-blocker.',
     );
   });
@@ -336,7 +336,7 @@ describe('sendFeedback', () => {
         email: 're@example.org',
         message: 'mi',
       }),
-    ).rejects.toMatch(
+    ).rejects.toThrow(
       'Unable to send feedback. This could be because of network issues, or because you are using an ad-blocker.',
     );
   });
@@ -353,7 +353,7 @@ describe('sendFeedback', () => {
         email: 're@example.org',
         message: 'mi',
       }),
-    ).rejects.toMatch(
+    ).rejects.toThrow(
       'Unable to send feedback. This could be because this domain is not in your list of allowed domains.',
     );
   });
@@ -389,7 +389,7 @@ describe('sendFeedback', () => {
 
     vi.advanceTimersByTime(30_000);
 
-    await expect(promise).rejects.toMatch('Unable to determine if Feedback was correctly sent.');
+    await expect(promise).rejects.toThrow('Unable to determine if Feedback was correctly sent.');
 
     vi.useRealTimers();
   });