Skip to content

Commit ffc6cd9

Browse files
billyvgbillyvg
committed
fix tests
1 parent c72a99c commit ffc6cd9

3 files changed

Lines changed: 14 additions & 155 deletions

File tree

‎dev-packages/browser-integration-tests/suites/replay/captureReplay/test.ts‎

Lines changed: 7 additions & 78 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { expect } from '@playwright/test';
2-
import { SDK_VERSION } from '@sentry/browser';
3-
import { sentryTest, TEST_HOST } from '../../../utils/fixtures';
2+
import { sentryTest } from '../../../utils/fixtures';
3+
import { getExpectedReplayEvent } from '../../../utils/replayEventTemplates';
44
import { getReplayEvent, shouldSkipReplayTest, waitForReplayRequest } from '../../../utils/replayHelpers';
55

66
sentryTest('should capture replays (@sentry/browser export)', async ({ getLocalTestUrl, page }) => {
@@ -20,84 +20,13 @@ sentryTest('should capture replays (@sentry/browser export)', async ({ getLocalT
2020
const replayEvent1 = getReplayEvent(await reqPromise1);
2121

2222
expect(replayEvent0).toBeDefined();
23-
expect(replayEvent0).toEqual({
24-
type: 'replay_event',
25-
timestamp: expect.any(Number),
26-
error_ids: [],
27-
trace_ids: [],
28-
urls: [`${TEST_HOST}/index.html`],
29-
replay_id: expect.stringMatching(/\w{32}/),
30-
replay_start_timestamp: expect.any(Number),
23+
expect(replayEvent0).toEqual(getExpectedReplayEvent({
3124
segment_id: 0,
32-
replay_type: 'session',
33-
event_id: expect.stringMatching(/\w{32}/),
34-
environment: 'production',
35-
sdk: {
36-
integrations: expect.arrayContaining([
37-
'InboundFilters',
38-
'FunctionToString',
39-
'BrowserApiErrors',
40-
'Breadcrumbs',
41-
'GlobalHandlers',
42-
'LinkedErrors',
43-
'Dedupe',
44-
'HttpContext',
45-
'BrowserSession',
46-
'Replay',
47-
]),
48-
version: SDK_VERSION,
49-
name: 'sentry.javascript.browser',
50-
settings: {
51-
infer_ip: 'never',
52-
},
53-
},
54-
request: {
55-
url: `${TEST_HOST}/index.html`,
56-
headers: {
57-
'User-Agent': expect.stringContaining(''),
58-
},
59-
},
60-
platform: 'javascript',
61-
});
25+
}));
6226

6327
expect(replayEvent1).toBeDefined();
64-
expect(replayEvent1).toEqual({
65-
type: 'replay_event',
66-
timestamp: expect.any(Number),
67-
error_ids: [],
68-
trace_ids: [],
69-
urls: [],
70-
replay_id: expect.stringMatching(/\w{32}/),
71-
replay_start_timestamp: expect.any(Number),
28+
expect(replayEvent1).toEqual(getExpectedReplayEvent({
7229
segment_id: 1,
73-
replay_type: 'session',
74-
event_id: expect.stringMatching(/\w{32}/),
75-
environment: 'production',
76-
sdk: {
77-
integrations: expect.arrayContaining([
78-
'InboundFilters',
79-
'FunctionToString',
80-
'BrowserApiErrors',
81-
'Breadcrumbs',
82-
'GlobalHandlers',
83-
'LinkedErrors',
84-
'Dedupe',
85-
'HttpContext',
86-
'BrowserSession',
87-
'Replay',
88-
]),
89-
version: SDK_VERSION,
90-
name: 'sentry.javascript.browser',
91-
settings: {
92-
infer_ip: 'never',
93-
},
94-
},
95-
request: {
96-
url: `${TEST_HOST}/index.html`,
97-
headers: {
98-
'User-Agent': expect.stringContaining(''),
99-
},
100-
},
101-
platform: 'javascript',
102-
});
30+
urls: [],
31+
}));
10332
});

‎dev-packages/browser-integration-tests/suites/replay/captureReplayFromReplayPackage/test.ts‎

Lines changed: 6 additions & 77 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { expect } from '@playwright/test';
2-
import { SDK_VERSION } from '@sentry/browser';
3-
import { sentryTest, TEST_HOST } from '../../../utils/fixtures';
2+
import { sentryTest } from '../../../utils/fixtures';
3+
import { getExpectedReplayEvent } from '../../../utils/replayEventTemplates';
44
import { getReplayEvent, shouldSkipReplayTest, waitForReplayRequest } from '../../../utils/replayHelpers';
55

66
sentryTest('should capture replays (@sentry-internal/replay export)', async ({ getLocalTestUrl, page }) => {
@@ -20,84 +20,13 @@ sentryTest('should capture replays (@sentry-internal/replay export)', async ({ g
2020
const replayEvent1 = getReplayEvent(await reqPromise1);
2121

2222
expect(replayEvent0).toBeDefined();
23-
expect(replayEvent0).toEqual({
24-
type: 'replay_event',
25-
timestamp: expect.any(Number),
26-
error_ids: [],
27-
trace_ids: [],
28-
urls: [`${TEST_HOST}/index.html`],
29-
replay_id: expect.stringMatching(/\w{32}/),
30-
replay_start_timestamp: expect.any(Number),
23+
expect(replayEvent0).toEqual(getExpectedReplayEvent({
3124
segment_id: 0,
32-
replay_type: 'session',
33-
event_id: expect.stringMatching(/\w{32}/),
34-
environment: 'production',
35-
sdk: {
36-
integrations: expect.arrayContaining([
37-
'InboundFilters',
38-
'FunctionToString',
39-
'BrowserApiErrors',
40-
'Breadcrumbs',
41-
'GlobalHandlers',
42-
'LinkedErrors',
43-
'Dedupe',
44-
'HttpContext',
45-
'BrowserSession',
46-
'Replay',
47-
]),
48-
version: SDK_VERSION,
49-
name: 'sentry.javascript.browser',
50-
settings: {
51-
infer_ip: 'never',
52-
},
53-
},
54-
request: {
55-
url: `${TEST_HOST}/index.html`,
56-
headers: {
57-
'User-Agent': expect.stringContaining(''),
58-
},
59-
},
60-
platform: 'javascript',
61-
});
25+
}));
6226

6327
expect(replayEvent1).toBeDefined();
64-
expect(replayEvent1).toEqual({
65-
type: 'replay_event',
66-
timestamp: expect.any(Number),
67-
error_ids: [],
68-
trace_ids: [],
28+
expect(replayEvent1).toEqual(getExpectedReplayEvent({
6929
urls: [],
70-
replay_id: expect.stringMatching(/\w{32}/),
71-
replay_start_timestamp: expect.any(Number),
7230
segment_id: 1,
73-
replay_type: 'session',
74-
event_id: expect.stringMatching(/\w{32}/),
75-
environment: 'production',
76-
sdk: {
77-
integrations: expect.arrayContaining([
78-
'InboundFilters',
79-
'FunctionToString',
80-
'BrowserApiErrors',
81-
'Breadcrumbs',
82-
'GlobalHandlers',
83-
'LinkedErrors',
84-
'Dedupe',
85-
'HttpContext',
86-
'BrowserSession',
87-
'Replay',
88-
]),
89-
version: SDK_VERSION,
90-
name: 'sentry.javascript.browser',
91-
settings: {
92-
infer_ip: 'never',
93-
},
94-
},
95-
request: {
96-
url: `${TEST_HOST}/index.html`,
97-
headers: {
98-
'User-Agent': expect.stringContaining(''),
99-
},
100-
},
101-
platform: 'javascript',
102-
});
31+
}));
10332
});

‎dev-packages/browser-integration-tests/utils/replayEventTemplates.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ const DEFAULT_REPLAY_EVENT = {
88
timestamp: expect.any(Number),
99
error_ids: [],
1010
trace_ids: [],
11+
traces_by_timestamp: [],
1112
urls: [expect.stringContaining('/index.html')],
1213
replay_id: expect.stringMatching(/\w{32}/),
1314
replay_start_timestamp: expect.any(Number),

0 commit comments

Comments
 (0)