feat(browser): Add experimental parentlessRootSpans browserTracingIntegration option#17527
Closed
feat(browser): Add experimental parentlessRootSpans browserTracingIntegration option#17527
parentlessRootSpans browserTracingIntegration option#17527Conversation
…Integration` option
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Member
Author
|
Going to close this because I want to revisit this more wholistically based on #17741 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experiment for now. TBD if we want to merge this.
This PR introduces a new idea how we continue SSR traces in the browser, based on
<meta>tags. Previously, we'd simply continue the trace as if the SSR server-side span was the parent span of thepageloadand all subsequent spans.This has a couple of disadvantages, espsecially when subsequent browser-local root spans spans were started: All of them would count as child spans of the initial
http.severspan. For some time, we had logic in the Sentry UI to artificially turn around the span relationships but this didn't work consistently within the trace view and even worse across multiple products. We'll fix this product-side by removing the reparenting logic and more clearly marking a trace as an SSR to explain why the trace looks like it does.But what, if it doesn't have to be this way?
With this PR, we're experimenting with a different way to connect browser-local root spans with the
http.serverspan:traceIdas well as of course the sampling decision and any other trace data items.parentSpanId. Instead, we explicitly do not set a parent span id, making the browser-local root spans become actual root spans in the trace.browser.requestspan that connects this span to the SSRhttp.serverspan. This should be enough information for the product, to eventually still show the connection in the trace view.Drawbacks:
http.serverspan is still not a child of thebrowser.requestspan. We can't solve this reliably on a technical level (requires major hacks, uncertainties and SDK changes across all our SDKs). The product can still artificially reparent these spans, though only this time, it knows exactly what to do and doesn't have to rely on heuristics.