feat(browser): Expose vercelai instrumentation#18347
Closed
nicohrubec wants to merge 3 commits intodevelopfrom
Closed
feat(browser): Expose vercelai instrumentation#18347nicohrubec wants to merge 3 commits intodevelopfrom
nicohrubec wants to merge 3 commits intodevelopfrom
Conversation
Contributor
size-limit report 📦
|
Lms24
previously approved these changes
Nov 27, 2025
Comment on lines
+5
to
+10
| // These tests are not exhaustive because the instrumentation is | ||
| // already tested in the node integration tests and we merely | ||
| // want to test that the instrumentation does not crash in the browser | ||
| // and that gen_ai transactions are sent. | ||
|
|
||
| sentryTest('manual Vercel AI instrumentation sends gen_ai transactions', async ({ getLocalTestUrl, page }) => { |
Member
There was a problem hiding this comment.
m: I don't have a super strong opinion here but given node and browser do have their differences, I'd prefer a bit stricter tests where we test against more data. Helps us find issues as well. Ill also defer to @RulaKhaled for the final call. Whatever you think makes most sense :)
Update: I bumped this to logaf-M: Can we check against some data that should be aded from our instrumentation? The attribute we check against is from the manually started span, no?
Member
|
Sorry, I dismissed my review because @andreiborza brought up an important question around this being effective in browser. Let's clarify this first. Happy to re-✅ afterwards |
Member
Author
|
Closing this as we don't use Otel in the browser so using the Vercel span processor in the browser doesn't do anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are exposing AI instrument methods for VercelAI enabling users to use it directly from the browser SDK.