Skip to content

fix(tanstackstart-react): remove misleading workerd/worker export conditions #20039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmalmo wants to merge 1 commit into from
Closed

fix(tanstackstart-react): remove misleading workerd/worker export conditions #20039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions packages/tanstackstart-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,6 @@
"./package.json": "./package.json",
".": {
"types": "./build/types/index.types.d.ts",
"workerd": {
"import": "./build/esm/index.server.js",
"require": "./build/cjs/index.server.js"
},
"worker": {
"import": "./build/esm/index.server.js",
"require": "./build/cjs/index.server.js"
},
Copy link
Copy Markdown

@cursor cursor Bot Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix PR lacks test for the regression

Low Severity

This is a fix PR but includes no unit, integration, or E2E test verifying that the regression (silent Worker crashes from the workerd/worker conditions resolving to @sentry/node) is fixed. Per the review rules, fix PRs need at least one test that would have failed before the fix and passes after it — e.g., a test asserting that the "." exports map no longer contains workerd or worker conditions, or an integration test confirming correct resolution for Workers bundlers.

Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

"browser": {
"import": "./build/esm/index.client.js",
"require": "./build/cjs/index.client.js"
Expand Down
Loading