feat(opentelemetry): Vendor AsyncLocalStorageContextManager#20243
Merged
feat(opentelemetry): Vendor AsyncLocalStorageContextManager#20243
AsyncLocalStorageContextManager#20243Conversation
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Core
Deps
Other
Bug Fixes 🐛Deno
Other
Internal Changes 🔧Ci
Deps
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
mydea
force-pushed
the
fn/vendor-otel-contextmanager
branch
from
7b409c3 to
8d14096
Compare
isaacs
approved these changes
Apr 13, 2026
Member
isaacs
left a comment
isaacs
left a comment
There was a problem hiding this comment.
This looks good to me, and combining two external deps into one internal is very nice.
| configurable: true, | ||
| writable: false, | ||
| value: target.length, | ||
| }); |
Member
There was a problem hiding this comment.
I am guessing that this is here to handle the express/connect pattern of treating (er, req, res, next) => {} differently from (req, res, next) => {}, but is it worth considering patching toString() as well, since we do that with our wrapped functions?
Member
Author
There was a problem hiding this comment.
hmm I basically just copy-pasted this from the original implementation - can you elaborate what exactly you mean? Can't quite find where we do this today?
This vendors in the required code from `@opentelemetry/context-async-hooks`
Co-authored-by: isaacs <i@izs.me>
mydea
force-pushed
the
fn/vendor-otel-contextmanager
branch
from
c12663f to
705e3c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This vendors in the required code from
@opentelemetry/context-async-hooks.This also deprecates the
wrapContextManagerClassmethod. It will continue to work until v11, but will be removed then - you'll no longer be able to use that, instead you'll have to use the provided context manager for integrated setup.Old code should continue to work as expected, but
@sentry/nodehas one dependency less (and node-core one peer dependency less) and should work the same as before.