ref(nextjs): Refactor findInjectionIndexAfterDirectives for better readability#20310
Merged
ref(nextjs): Refactor findInjectionIndexAfterDirectives for better readability#20310
findInjectionIndexAfterDirectives for better readability#20310Conversation
mydea
pushed a commit
that referenced
this pull request
Apr 15, 2026
…readability (#20310) Builds on top of this PR: #20103 Adds some explaining comments and refactors the directive-scanning logic in the value injection loader from 4 functions down to 3 by inlining whitespace and comment skipping into the main loop. The previous implementation split the scanning into a separate `skipWhitespaceAndComments` function. The new version handles whitespace, line comments, and block comments as continue branches directly in the main while loop, which: - Eliminates one level of function calls - Unterminated block comments are handled inline with an early return - Makes the control flow easier to follow. Each iteration of the loop either skips something inert (whitespace/comments), successfully parses a directive and advances, or exits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of this PR: #20103
Adds some explaining comments and refactors the directive-scanning logic in the value injection loader from 4 functions down to 3 by inlining whitespace and comment skipping into the main loop.
The previous implementation split the scanning into a separate
skipWhitespaceAndCommentsfunction. The new version handles whitespace, line comments, and block comments as continue branches directly in the main while loop, which: