Skip to content

chore(ci): Do not build AWS lambda layer in build step #20357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mydea wants to merge 13 commits into from
Closed

chore(ci): Do not build AWS lambda layer in build step #20357

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7203205
perf(aws-serverless): Speed up Lambda layer build with tarball-based …
mydea Apr 16, 2026
b57849c
chore(ci): Do not build AWS lambda layer in build step
mydea Apr 16, 2026
b26d4fb
Revert "perf(aws-serverless): Speed up Lambda layer build with tarbal…
mydea Apr 16, 2026
df7849c
ensure extension is run for tarball as well
mydea Apr 16, 2026
3500c6b
avoid build dev change
mydea Apr 16, 2026
d8898a4
better dependency graph
mydea Apr 17, 2026
7ffc0b8
fix job
mydea Apr 17, 2026
7ca058d
only run layer build when needed
mydea Apr 17, 2026
943eb4b
fix path
mydea Apr 17, 2026
fc5fbff
use path directly
mydea Apr 17, 2026
cab77a9
ensure tarball depends on extension
mydea Apr 17, 2026
f1e1d97
build and cache extension
mydea Apr 17, 2026
19230d7
avoid unnecessary build cache
mydea Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,27 @@ jobs:
${{ needs.job_get_metadata.outputs.changed_ci == 'true' || contains(steps.checkForAffected.outputs.affected,
'@sentry-internal/browser-integration-tests') }}

job_verify_build_layer:
name: Verify Lambda layer build
needs: [job_get_metadata, job_build]
timeout-minutes: 10
runs-on: ubuntu-24.04
steps:
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
uses: actions/checkout@v6
with:
ref: ${{ env.HEAD_COMMIT }}
- name: Set up Node
uses: actions/setup-node@v6
with:
node-version-file: 'package.json'
- name: Restore caches
uses: ./.github/actions/restore-cache
with:
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
- name: Build Lambda layer
run: yarn build:layer

job_check_branches:
name: Check PR branches
needs: job_get_metadata
Expand Down Expand Up @@ -319,6 +340,9 @@ jobs:
- name: Pack tarballs
run: yarn build:tarball

- name: Build Lambda layer
run: yarn build:layer
Comment thread
cursor[bot] marked this conversation as resolved.
Outdated

- name: Archive artifacts
uses: actions/upload-artifact@v7
with:
Expand Down Expand Up @@ -1134,6 +1158,7 @@ jobs:
job_check_lockfile,
job_check_format,
job_circular_dep_check,
job_verify_build_layer,
Comment thread
sentry[bot] marked this conversation as resolved.
Outdated
job_size_check,
]
# Always run this, even if a dependent job failed
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
{
"private": true,
"scripts": {
"build": "node ./scripts/verify-packages-versions.js && nx run-many -t build:transpile build:types build:bundle build:layer",
"build": "node ./scripts/verify-packages-versions.js && nx run-many -t build:transpile build:types build:bundle",
Comment thread
cursor[bot] marked this conversation as resolved.
Outdated
"build:bundle": "nx run-many -t build:bundle",
"build:layer": "nx run-many -t build:layer",
"build:dev": "nx run-many -t build:types build:transpile",
"build:dev:filter": "nx run-many -t build:dev -p",
"build:transpile": "nx run-many -t build:transpile",
Expand Down
4 changes: 2 additions & 2 deletions packages/aws-serverless/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,10 @@
"@vercel/nft": "^1.3.0"
},
"scripts": {
"build": "run-p build:transpile build:types build:extension && run-s build:layer",
"build": "run-p build:transpile build:types build:extension",
"build:extension": "rollup -c rollup.lambda-extension.config.mjs && yarn ts-node scripts/buildLambdaExtension.ts",
"build:layer": "rimraf build/aws && yarn ts-node scripts/buildLambdaLayer.ts",
"build:dev": "run-p build:transpile build:types",
"build:dev": "run-p build:transpile build:types build:extension",
Comment thread
sentry[bot] marked this conversation as resolved.
Outdated
"build:transpile": "rollup -c rollup.npm.config.mjs",
"build:types": "run-s build:types:core build:types:downlevel",
"build:types:core": "tsc -p tsconfig.types.json",
Expand Down
Loading