Skip to content

fix(node): Guard against null httpVersion in outgoing request span attributes #20430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
logaretm merged 3 commits into from
Apr 22, 2026
Merged

fix(node): Guard against null httpVersion in outgoing request span attributes #20430

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d64142
fix(node): Guard against null `httpVersion` in outgoing request span …
logaretm Apr 21, 2026
1dc6e72
Update packages/node-core/src/integrations/http/SentryHttpInstrumenta…
logaretm Apr 21, 2026
bf64097
test(node-core): Add unit tests for `_getOutgoingRequestEndedSpanData…
logaretm Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/node-core/src/integrations/http/SentryHttpInstrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,10 @@ function _getOutgoingRequestSpanData(request: http.ClientRequest): [string, Span
function _getOutgoingRequestEndedSpanData(response: http.IncomingMessage): SpanAttributes {
const { statusCode, statusMessage, httpVersion, socket } = response;

const transport = httpVersion.toUpperCase() !== 'QUIC' ? 'ip_tcp' : 'ip_udp';
// httpVersion can be undefined in some cases and we seem to hav encountered this before:
Comment thread
logaretm marked this conversation as resolved.
Outdated
Comment thread
logaretm marked this conversation as resolved.
Outdated
// https://github.com/getsentry/sentry-javascript/blob/ec8c8c64cde6001123db0199a8ca017b8863eac8/packages/node-core/src/integrations/http/httpServerSpansIntegration.ts#L158
// see: #20415
const transport = httpVersion?.toUpperCase() !== 'QUIC' ? 'ip_tcp' : 'ip_udp';
Comment thread
logaretm marked this conversation as resolved.

const additionalAttributes: SpanAttributes = {
[ATTR_HTTP_RESPONSE_STATUS_CODE]: statusCode,
Expand Down
Loading