feat(deno): redis diagnostics channel based integration for deno#21087
Open
isaacs wants to merge 2 commits into
Open
feat(deno): redis diagnostics channel based integration for deno#21087isaacs wants to merge 2 commits into
isaacs wants to merge 2 commits into
Conversation
isaacs
requested review from
andreiborza and
mydea
and removed request for
a team
Contributor
size-limit report 📦
|
) Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test.
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
f176fd8 to
0fc320c
Compare
isaacs
added a commit
that referenced
this pull request
May 20, 2026
isaacs
force-pushed
the
isaacs/deno-redis-dc
branch
from
1048f32 to
72be1fa
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 72be1fa. Configure here.
| if: matrix.test-application == 'deno' || matrix.test-application == 'deno-streamed' | ||
| if: | ||
| matrix.test-application == 'deno' || matrix.test-application == 'deno-streamed' || matrix.test-application == | ||
| 'deno-redis' |
There was a problem hiding this comment.
E2E CI uses outdated Deno version for deno-redis
High Severity
The E2E test job sets deno-version: v2.1.5 for deno-redis, but the denoRedisIntegration and the test app explicitly require Deno 2.7.13+ (as stated in the app comment at line 15 of app.ts). The unit test job was correctly updated to v2.7.14 at line 530, but the E2E test job was not. The deno-redis E2E tests will likely fail or produce incorrect results running on a Deno version that is too old.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 72be1fa. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns.
Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds
_sentrySpanonto the data in a RedisTracingChannelFactory which is passed to the core utility.