fix(cloudflare): Skip SDK initialization for OPTIONS/HEAD requests#21090
Open
JPeer264 wants to merge 2 commits into
Open
fix(cloudflare): Skip SDK initialization for OPTIONS/HEAD requests#21090JPeer264 wants to merge 2 commits into
JPeer264 wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
JPeer264
requested review from
andreiborza and
mydea
and removed request for
a team
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6424081. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #21022
closes JS-2553
OPTIONS and HEAD requests now bypass SDK initialization entirely, eliminating ~450ms overhead per request. The early bail-out happens before any SDK work (OTel setup, integrations, init) runs.
This matches the Bun SDK's approach and addresses the performance issue where
withSentrymutateshandler.fetchin place, causing even "bypassed" requests to incur full init cost.This will get rid of
captureExceptions for these requests. Then again OPTIONS are just CORS preflight requests and should perform quick for the next request. Same for HEAD.I played around to actually test against response times in an integration test, but they were not really reliable, even locally, so I decided to keep unit tests only. I also let the old behavior in as the
wrapRequesetHandleris exposed and used in other SDKs (see #21090 (comment))