feat(nextjs): Migrate sendDefaultPii to dataCollection#21137
Open
chargome wants to merge 3 commits into
Open
Conversation
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| const result = addHeadersAsAttributes({ 'content-type': 'application/json' }); | ||
| expect(result).toEqual({}); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Feat PR lacks integration or E2E test coverage
Low Severity
This is a feat PR that migrates multiple code paths from sendDefaultPii to the dataCollection API, but the diff only includes unit tests (with heavy mocking). No integration or E2E test is present to validate the end-to-end behavior of these data-collection changes within an actual Next.js application. Per the review rules, feat PRs need at least one integration or E2E test. Flagging this because it was mentioned in the rules file.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 1ea8c62. Configure here.
Member
Author
There was a problem hiding this comment.
we got existing tests that cover this
chargome
force-pushed
the
cg/next-datacollection
branch
from
1ea8c62 to
0d290e1
Compare
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
1 issue from previous review remains unresolved.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0d290e1. Configure here.
chargome
requested review from
logaretm,
nicohrubec and
s1gr1d
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate
sendDefaultPiiusage in the Next.js package to thedataCollectionAPI:withServerActionInstrumentation: UsegetDataCollectionOptions().httpBodies.includes('outgoingResponse')to gate server action response recordingaddHeadersAsAttributes: UsehttpHeaders.requestfromgetDataCollectionOptions()to control header span attributes and filtering levelsetUrlProcessingMetadata: Remove thesendDefaultPiigate — URLs are fundamental request metadata, not PII-gated data (see spec update)pagesRouterRoutingInstrumentation: Remove thesendDefaultPiigate for route params — same reasoning as URLsref getsentry/sentry-docs#17911
closes #20932