feat(hono): Emit warning if @sentry/node was imported instead of @sentry/hono/node#21240
Merged
Conversation
…sentry/hono/node`
nicohrubec
approved these changes
May 29, 2026
| if (!isInitializedWithHonoSdk) { | ||
| consoleSandbox(() => { | ||
| // eslint-disable-next-line no-console | ||
| console.warn( |
Member
There was a problem hiding this comment.
l: so this one we want to always show and the other warnings only as debug logs? is that intentional?
Member
Author
There was a problem hiding this comment.
It's intentional as it should always be shown (it's pretty important). The first log is also pretty important, I'm gonna change this to console. The third log in the file is really just a debug log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Hono Node setup requires a separate instrumentation file with the
Sentry.init()call. It's important thatinitis imported from the Hono SDK and not Node. As this could easily be overlooked, but is very important for the correct setup, this warning is added.