style: Migrate to ktlint_official code style#561
Open
buenaflor wants to merge 2 commits into
Open
Conversation
Remove the intellij_idea style pin introduced with the Spotless 7 / ktlint 1.x upgrade and adopt ktlint's default ktlint_official code style: run spotlessApply across the repo, add the explicit Unit return type that explicit-api mode requires after the expression-body conversion in SentryKMP, and regenerate the detekt baseline for the reformat-induced MaxLineLength findings. Also wire DetektCreateBaselineTask to the same sources/excludes as the Detekt tasks so ./gradlew detektBaseline actually regenerates the shared baseline. No functional change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Migrates the repository to ktlint’s default ktlint_official code style by removing the legacy style pin and applying the resulting Spotless/ktlint reformat across the codebase, alongside updating detekt baseline generation wiring.
Changes:
- Remove the legacy ktlint style pin and apply
ktlint_officialformatting across Kotlin/KTS sources. - Wire detekt baseline generation to the correct source set/excludes and regenerate the baseline.
- Adjust one public API (
Sentry.captureUserFeedback) to satisfy explicit-api requirements after expression-body formatting.
Reviewed changes
Copilot reviewed 146 out of 147 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sentry-samples/kmp-app-spm/shared/src/iosMain/kotlin/sample.kmp.app/HttpClient.kt | Formatting-only changes (chained call wrapping). |
| sentry-samples/kmp-app-spm/shared/src/commonMain/kotlin/sample.kmp.app/SentrySetup.kt | Formatting-only changes (trailing commas, expression body). |
| sentry-samples/kmp-app-spm/shared/src/commonMain/kotlin/sample.kmp.app/LoginImpl.kt | Formatting-only changes (wrapping/indentation). |
| sentry-samples/kmp-app-spm/shared/build.gradle.kts | Formatting-only change (trailing comma). |
| sentry-samples/kmp-app-spm/desktopApp/src/jvmMain/kotlin/sample.kmp.app.desktop/Main.kt | Formatting-only changes (trailing commas, expression body). |
| sentry-kotlin-multiplatform/src/jvmTest/kotlin/io/sentry/kotlin/multiplatform/PlatformOptions.jvm.kt | Formatting-only changes (wrapping, expression body). |
| sentry-kotlin-multiplatform/src/jvmTest/kotlin/io/sentry/kotlin/multiplatform/BaseSentryTest.kt | Formatting-only change (blank line). |
| sentry-kotlin-multiplatform/src/jvmMain/kotlin/io/sentry/kotlin/multiplatform/SentryPlatformOptions.jvm.kt | Formatting-only change (expression body layout). |
| sentry-kotlin-multiplatform/src/iosTest/kotlin/io/sentry/kotlin/multiplatform/PlatformOptions.ios.kt | Formatting-only changes (wrapping, multiline assertion). |
| sentry-kotlin-multiplatform/src/iosMain/kotlin/io/sentry/kotlin/multiplatform/SentryPlatformOptions.ios.kt | Formatting-only change (expression body layout). |
| sentry-kotlin-multiplatform/src/iosMain/kotlin/io/sentry/kotlin/multiplatform/extensions/SentryOptionsExtensions.ios.kt | Formatting-only changes (wrapping, trailing commas). |
| sentry-kotlin-multiplatform/src/commonTvWatchMacOsTest/kotlin/io/sentry/kotlin/multiplatform/PlatformOptions.tvwatchmacos.kt | Formatting-only changes (class header wrapping). |
| sentry-kotlin-multiplatform/src/commonTvWatchMacOsMain/kotlin/io/sentry/kotlin/multiplatform/SentryPlatformOptions.tvwatchmacos.kt | Formatting-only change (expression body layout). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/UserTest.kt | Formatting-only change (expression body). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/UserFeedbackTest.kt | Formatting-only change (blank line removal). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/SentryOptionsTest.kt | Formatting-only changes (wrapping/indentation). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/SentryLevelTestConverter.kt | Formatting-only change (blank line removal). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/SentryLevelConversionTest.kt | Formatting-only change (blank line removal). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/SentryIntegrationTest.kt | Formatting-only changes (wrapping, trailing commas, expression body). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/SentryIdTest.kt | Formatting-only change (blank line removal). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/SentryEventTest.kt | Formatting-only change (blank line removal). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/SentryEventConfigurator.kt | Formatting-only changes (blank lines). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/SentryE2ETest.kt | Formatting-only changes (wrapping, trailing commas, expression body). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/SentryBridgeTest.kt | Formatting-only changes (blank lines). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/SentryAttributeValueTest.kt | Formatting-only change (blank line removal). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/SentryAttributesTest.kt | Formatting-only changes (wrapping, trailing commas). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/ScopeTest.kt | Formatting-only changes (expression body). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/log/SentryLogOptionsTest.kt | Formatting-only changes (trailing comma). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/log/SentryLogBuilderTest.kt | Formatting-only change (blank line removal). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/log/BaseSentryLoggerTest.kt | Formatting-only changes (wrapping, trailing commas). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/BreadcrumbTestConverter.kt | Formatting-only changes (class header wrapping, blank lines). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/BreadcrumbTest.kt | Formatting-only change (blank line removal). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/BreadcrumbConfigurator.kt | Formatting-only changes (blank lines). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/BeforeSendTest.kt | Formatting-only changes (wrapping, trailing commas). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/BeforeBreadcrumbIntegrationTest.kt | Formatting-only changes (wrapping/indentation). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/BaseSentryTest.kt | Formatting-only changes (blank lines). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/BaseSentryScopeTest.kt | Formatting-only change (blank line removal). |
| sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/AttachmentTest.kt | Formatting-only change (blank line removal). |
| sentry-kotlin-multiplatform/src/commonStub/kotlin/io/sentry/kotlin/multiplatform/SentryBridge.commonStub.kt | Formatting-only changes (wrapping, expression bodies). |
| sentry-kotlin-multiplatform/src/commonStub/kotlin/io/sentry/kotlin/multiplatform/protocol/SentryId.commonStub.kt | Formatting-only changes (constructor wrapping). |
| sentry-kotlin-multiplatform/src/commonStub/kotlin/io/sentry/kotlin/multiplatform/NoOpSentryLogger.kt | Formatting-only changes (method signature wrapping, trailing commas). |
| sentry-kotlin-multiplatform/src/commonStub/kotlin/io/sentry/kotlin/multiplatform/Attachment.commonStub.kt | Formatting-only change (blank line removal). |
| sentry-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/SentryReplayOptions.kt | Formatting-only changes (trailing commas). |
| sentry-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/SentryLevel.kt | Formatting-only changes (enum formatting, expression bodies). |
| sentry-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/SentryKMP.kt | Formatting migration plus explicit : Unit for captureUserFeedback under explicit-api mode. |
| sentry-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/SentryBridge.kt | Formatting-only changes (signature wrapping). |
| sentry-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/SentryBaseEvent.kt | Formatting-only changes (trailing commas, signature wrapping). |
| sentry-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/SentryAttributeValue.kt | Formatting-only changes (constructor wrapping, trailing commas). |
| sentry-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/SentryAttributes.kt | Formatting-only changes (signature wrapping; companion factory expression body). |
| sentry-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/Scope.kt | Formatting-only changes (signature wrapping). |
| sentry-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/protocol/UserFeedback.kt | Formatting-only change (trailing comma). |
| sentry-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/protocol/User.kt | Formatting-only changes (trailing commas). |
| sentry-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/protocol/SentryId.kt | Formatting-only changes (constructor wrapping, blank line). |
| sentry-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/protocol/SentryException.kt | Formatting-only change (trailing comma). |
| sentry-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/protocol/SdkVersion.kt | Formatting-only changes (trailing comma, signature wrapping). |
| sentry-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/protocol/Message.kt | Formatting-only change (trailing comma). |
| sentry-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/protocol/Breadcrumb.kt | Formatting-only changes (factory methods expression bodies, wrapping, trailing commas). |
| sentry-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/log/SentryLogLevel.kt | Formatting-only change (trailing comma). |
| sentry-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/log/SentryLogBuilder.kt | Formatting-only changes (signature wrapping, trailing comma). |
| sentry-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/log/SentryLog.kt | Formatting-only changes (trailing commas). |
| sentry-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/log/DefaultSentryLogBuilder.kt | Formatting-only changes (wrapping, trailing commas). |
| sentry-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/HttpStatusCodeRange.kt | Formatting-only changes (data class wrapping, expression body). |
| sentry-kotlin-multiplatform/src/commonMain/kotlin/io/sentry/kotlin/multiplatform/Attachment.kt | Formatting-only change (blank line removal). |
| sentry-kotlin-multiplatform/src/commonJvmTest/kotlin/io/sentry/kotlin/multiplatform/SentryLevelTestConverter.kt | Formatting-only change (expression body). |
| sentry-kotlin-multiplatform/src/commonJvmTest/kotlin/io/sentry/kotlin/multiplatform/SentryBridgeTest.commonJvm.kt | Formatting-only changes (wrapping/indentation). |
| sentry-kotlin-multiplatform/src/commonJvmTest/kotlin/io/sentry/kotlin/multiplatform/SentryAttributesConversionTest.kt | Formatting-only change (expression body). |
| sentry-kotlin-multiplatform/src/commonJvmTest/kotlin/io/sentry/kotlin/multiplatform/JvmSentryIdTest.kt | Formatting-only change (blank line removal). |
| sentry-kotlin-multiplatform/src/commonJvmTest/kotlin/io/sentry/kotlin/multiplatform/BreadcrumbTestConverter.kt | Formatting-only changes (constructor wrapping, expression bodies). |
| sentry-kotlin-multiplatform/src/commonJvmMain/kotlin/io/sentry/kotlin/multiplatform/SentryBridge.commonJvm.kt | Formatting-only changes (wrapping, expression bodies). |
| sentry-kotlin-multiplatform/src/commonJvmMain/kotlin/io/sentry/kotlin/multiplatform/protocol/SentryId.jvm.kt | Formatting-only changes (constructor wrapping, init wrapping, expression body). |
| sentry-kotlin-multiplatform/src/commonJvmMain/kotlin/io/sentry/kotlin/multiplatform/log/SentryLogConverters.jvm.kt | Formatting-only changes (when formatting, wrapping, trailing commas). |
| sentry-kotlin-multiplatform/src/commonJvmMain/kotlin/io/sentry/kotlin/multiplatform/log/JvmSentryLoggerAdapter.kt | Formatting-only changes (constructor/method signature wrapping, trailing comma). |
| sentry-kotlin-multiplatform/src/commonJvmMain/kotlin/io/sentry/kotlin/multiplatform/JvmScopeProvider.kt | Formatting-only changes (class header/method signature wrapping, expression bodies). |
| sentry-kotlin-multiplatform/src/commonJvmMain/kotlin/io/sentry/kotlin/multiplatform/extensions/UserExtensions.jvm.kt | Formatting-only changes (expression bodies, indentation). |
| sentry-kotlin-multiplatform/src/commonJvmMain/kotlin/io/sentry/kotlin/multiplatform/extensions/SentryOptionsExtensions.jvm.kt | Formatting-only changes (wrapping). |
| sentry-kotlin-multiplatform/src/commonJvmMain/kotlin/io/sentry/kotlin/multiplatform/extensions/SentryLevelExtensions.jvm.kt | Formatting-only changes (expression bodies). |
| sentry-kotlin-multiplatform/src/commonJvmMain/kotlin/io/sentry/kotlin/multiplatform/extensions/SentryExceptionExtensions.jvm.kt | Formatting-only changes (wrapping, trailing comma). |
| sentry-kotlin-multiplatform/src/commonJvmMain/kotlin/io/sentry/kotlin/multiplatform/extensions/MessageExtensions.jvm.kt | Formatting-only changes (wrapping, trailing comma). |
| sentry-kotlin-multiplatform/src/commonJvmMain/kotlin/io/sentry/kotlin/multiplatform/extensions/BreadcrumbExtensions.jvm.kt | Formatting-only changes (wrapping/indentation). |
| sentry-kotlin-multiplatform/src/commonJvmMain/kotlin/io/sentry/kotlin/multiplatform/Attachment.jvm.kt | Formatting-only changes (expression body, blank line removal). |
| sentry-kotlin-multiplatform/src/appleTest/kotlin/io/sentry/kotlin/multiplatform/UserFeedbackExtensionsTest.kt | Formatting-only changes (wrapping/indentation). |
| sentry-kotlin-multiplatform/src/appleTest/kotlin/io/sentry/kotlin/multiplatform/SentryLevelTestConverter.kt | Formatting-only change (expression body). |
| sentry-kotlin-multiplatform/src/appleTest/kotlin/io/sentry/kotlin/multiplatform/SentryExceptionTest.kt | Formatting-only changes (wrapping/indentation). |
| sentry-kotlin-multiplatform/src/appleTest/kotlin/io/sentry/kotlin/multiplatform/SentryBridgeTest.apple.kt | Formatting-only changes (wrapping/indentation). |
| sentry-kotlin-multiplatform/src/appleTest/kotlin/io/sentry/kotlin/multiplatform/SentryAttributesConversionTest.kt | Formatting-only change (expression body). |
| sentry-kotlin-multiplatform/src/appleTest/kotlin/io/sentry/kotlin/multiplatform/PlatformOptions.apple.kt | Formatting-only changes (class header wrapping, expression body). |
| sentry-kotlin-multiplatform/src/appleTest/kotlin/io/sentry/kotlin/multiplatform/nsexception/ThrowableReasonTests.kt | Formatting-only changes (signature wrapping, trailing commas). |
| sentry-kotlin-multiplatform/src/appleTest/kotlin/io/sentry/kotlin/multiplatform/nsexception/ThrowableNameTests.kt | Formatting-only change (blank line removal). |
| sentry-kotlin-multiplatform/src/appleTest/kotlin/io/sentry/kotlin/multiplatform/nsexception/ThrowableCausesTests.kt | Formatting-only changes (constructor wrapping). |
| sentry-kotlin-multiplatform/src/appleTest/kotlin/io/sentry/kotlin/multiplatform/nsexception/InitAddressesTests.kt | Formatting-only changes (array formatting, trailing comma). |
| sentry-kotlin-multiplatform/src/appleTest/kotlin/io/sentry/kotlin/multiplatform/BreadcrumbTestConverter.kt | Formatting-only changes (constructor wrapping, expression bodies). |
| sentry-kotlin-multiplatform/src/appleTest/kotlin/io/sentry/kotlin/multiplatform/BaseSentryTest.kt | Formatting-only change (blank line). |
| sentry-kotlin-multiplatform/src/appleTest/kotlin/io/sentry/kotlin/multiplatform/ApplyKmpEventTest.kt | Formatting-only changes (wrapping/indentation). |
| sentry-kotlin-multiplatform/src/appleTest/kotlin/io/sentry/kotlin/multiplatform/AppleSentryIdTest.kt | Formatting-only change (blank line removal). |
| sentry-kotlin-multiplatform/src/appleMain/kotlin/io/sentry/kotlin/multiplatform/SentryEvent.apple.kt | Formatting-only changes (wrapping). |
| sentry-kotlin-multiplatform/src/appleMain/kotlin/io/sentry/kotlin/multiplatform/SentryBridge.apple.kt | Formatting-only changes (wrapping, expression bodies). |
| sentry-kotlin-multiplatform/src/appleMain/kotlin/io/sentry/kotlin/multiplatform/protocol/SentryId.apple.kt | Formatting-only changes (constructor wrapping, init wrapping, expression body). |
| sentry-kotlin-multiplatform/src/appleMain/kotlin/io/sentry/kotlin/multiplatform/nsexception/Throwable.kt | Formatting-only changes (wrapping, trailing commas). |
| sentry-kotlin-multiplatform/src/appleMain/kotlin/io/sentry/kotlin/multiplatform/nsexception/NSException.kt | Formatting-only changes (wrapping, trailing commas). |
| sentry-kotlin-multiplatform/src/appleMain/kotlin/io/sentry/kotlin/multiplatform/log/SentryLogConverters.apple.kt | Formatting-only changes (when formatting, wrapping, trailing commas). |
| sentry-kotlin-multiplatform/src/appleMain/kotlin/io/sentry/kotlin/multiplatform/log/CocoaSentryLoggerAdapter.kt | Formatting-only changes (constructor/method signature wrapping, trailing comma). |
| sentry-kotlin-multiplatform/src/appleMain/kotlin/io/sentry/kotlin/multiplatform/extensions/UserExtensions.apple.kt | Formatting-only changes (expression bodies, indentation). |
| sentry-kotlin-multiplatform/src/appleMain/kotlin/io/sentry/kotlin/multiplatform/extensions/SentryOptionsExtensions.apple.kt | Formatting-only changes (wrapping/indentation, trailing commas). |
| sentry-kotlin-multiplatform/src/appleMain/kotlin/io/sentry/kotlin/multiplatform/extensions/SentryExceptionExtensions.apple.kt | Formatting-only changes (wrapping, trailing comma). |
| sentry-kotlin-multiplatform/src/appleMain/kotlin/io/sentry/kotlin/multiplatform/extensions/MessageExtensions.apple.kt | Formatting-only changes (wrapping, trailing comma). |
| sentry-kotlin-multiplatform/src/appleMain/kotlin/io/sentry/kotlin/multiplatform/extensions/FoundationExtensions.kt | Formatting-only changes (expression bodies, trailing commas). |
| sentry-kotlin-multiplatform/src/appleMain/kotlin/io/sentry/kotlin/multiplatform/extensions/BreadcrumbExtensions.apple.kt | Formatting-only changes (expression bodies, indentation). |
| sentry-kotlin-multiplatform/src/appleMain/kotlin/io/sentry/kotlin/multiplatform/CocoaScopeProvider.kt | Formatting-only changes (class header/method signature wrapping). |
| sentry-kotlin-multiplatform/src/appleMain/kotlin/io/sentry/kotlin/multiplatform/Attachment.apple.kt | Formatting-only changes (expression body, blank line removal). |
| sentry-kotlin-multiplatform/src/androidUnitTest/kotlin/io/sentry/kotlin/multiplatform/SentryAndroidBridgeTest.kt | Formatting-only changes (wrapping, expression body). |
| sentry-kotlin-multiplatform/src/androidUnitTest/kotlin/io/sentry/kotlin/multiplatform/PlatformOptions.android.kt | Formatting-only changes (wrapping, trailing commas, expression body). |
| sentry-kotlin-multiplatform/src/androidUnitTest/kotlin/io/sentry/kotlin/multiplatform/BaseSentryTest.kt | Formatting-only change (blank line). |
| sentry-kotlin-multiplatform/src/androidMain/kotlin/io/sentry/kotlin/multiplatform/SentryPlatformOptions.android.kt | Formatting-only change (expression body layout). |
| sentry-kotlin-multiplatform/src/androidMain/kotlin/io/sentry/kotlin/multiplatform/SentryPlatformInstance.android.kt | Formatting-only changes (wrapping). |
| sentry-kotlin-multiplatform/src/androidMain/kotlin/io/sentry/kotlin/multiplatform/extensions/SentryOptionsExtensions.android.kt | Formatting-only changes (wrapping/indentation). |
| sentry-kotlin-multiplatform/src/androidMain/kotlin/io/sentry/kotlin/multiplatform/Context.android.kt | Formatting-only changes (signature wrapping, trailing commas). |
| sentry-kotlin-multiplatform/build.gradle.kts | Formatting-only changes (trailing commas). |
| sentry-kotlin-multiplatform-gradle-plugin/src/test/java/io/sentry/kotlin/multiplatform/gradle/SentryPluginTest.kt | Formatting-only changes (wrapping/indentation). |
| sentry-kotlin-multiplatform-gradle-plugin/src/test/java/io/sentry/kotlin/multiplatform/gradle/SentryFrameworkArchitectureTest.kt | Formatting-only changes (wrapping, trailing commas). |
| sentry-kotlin-multiplatform-gradle-plugin/src/test/java/io/sentry/kotlin/multiplatform/gradle/ManualSearchStrategyTest.kt | Formatting-only changes (trailing commas, wrapping). |
| sentry-kotlin-multiplatform-gradle-plugin/src/test/java/io/sentry/kotlin/multiplatform/gradle/FrameworkPathResolverTest.kt | Formatting-only changes (wrapping). |
| sentry-kotlin-multiplatform-gradle-plugin/src/test/java/io/sentry/kotlin/multiplatform/gradle/DerivedDataStrategyTest.kt | Formatting-only changes (wrapping/indentation, trailing commas). |
| sentry-kotlin-multiplatform-gradle-plugin/src/test/java/io/sentry/kotlin/multiplatform/gradle/DerivedDataPathTest.kt | Formatting-only changes (wrapping/indentation). |
| sentry-kotlin-multiplatform-gradle-plugin/src/test/java/io/sentry/kotlin/multiplatform/gradle/CustomPathStrategyTest.kt | Formatting-only changes (wrapping, trailing commas). |
| sentry-kotlin-multiplatform-gradle-plugin/src/test/java/io/sentry/kotlin/multiplatform/gradle/CocoaFrameworkLinkerTest.kt | Formatting-only changes (wrapping, expression bodies). |
| sentry-kotlin-multiplatform-gradle-plugin/src/test/java/io/sentry/kotlin/multiplatform/gradle/CocoaFrameworkLinkerIntegrationTest.kt | Formatting-only changes (wrapping/indentation, trailing commas). |
| sentry-kotlin-multiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/Spm4KmpAutoInstallExtension.kt | Formatting-only changes (constructor/property wrapping, trailing commas). |
| sentry-kotlin-multiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/SourceSetAutoInstallExtension.kt | Formatting-only changes (constructor/property wrapping, trailing commas). |
| sentry-kotlin-multiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/SentryPlugin.kt | Formatting changes; also contains a compile-breaking mixed named/positional argument call (needs fix). |
| sentry-kotlin-multiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/SentryExtension.kt | Formatting-only changes (constructor/property wrapping). |
| sentry-kotlin-multiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/ManualFrameworkPathSearchValueSource.kt | Formatting-only changes (wrapping, trailing commas). |
| sentry-kotlin-multiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/LinkerExtension.kt | Formatting-only changes (constructor/property wrapping). |
| sentry-kotlin-multiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/FrameworkLinker.kt | Formatting-only changes (signature wrapping, trailing commas). |
| sentry-kotlin-multiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/DerivedDataPathValueSource.kt | Formatting-only changes (wrapping, trailing commas). |
| sentry-kotlin-multiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/CocoapodsAutoInstallExtension.kt | Formatting-only changes (constructor/property wrapping). |
| sentry-kotlin-multiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/CocoaFrameworkLinker.kt | Formatting-only changes (wrapping, trailing commas). |
| sentry-kotlin-multiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/AutoInstallExtension.kt | Formatting-only changes (constructor/property wrapping). |
| sentry-kotlin-multiplatform-gradle-plugin/build.gradle.kts | Formatting-only changes (trailing commas). |
| config/detekt/baseline.xml | Regenerated baseline (includes new MaxLineLength suppressions). |
| buildSrc/src/main/java/Publication.kt | Formatting-only changes (wrapping, trailing commas). |
| build.gradle.kts | Removes ktlint style pin, wires detekt baseline tasks to sources/excludes, and updates excludes. |
| .editorconfig | Removes legacy ktlint style pin and keeps naming-rule disables. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
90
to
94
| maybeLinkCocoaFramework( | ||
| project, | ||
| frameworkProvidedExternally = hasCocoapodsPlugin || hasSpm4KmpPlugin, | ||
| hostIsMac | ||
| hostIsMac, | ||
| ) |
romtsn
approved these changes
Jun 11, 2026
…nt-official # Conflicts: # sentry-kotlin-multiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/SentryPlugin.kt # sentry-kotlin-multiplatform-gradle-plugin/src/main/java/io/sentry/kotlin/multiplatform/gradle/Spm4KmpAutoInstallExtension.kt # sentry-kotlin-multiplatform/src/appleMain/kotlin/io/sentry/kotlin/multiplatform/nsexception/SentryUnhandledExceptions.kt # sentry-kotlin-multiplatform/src/commonTest/kotlin/io/sentry/kotlin/multiplatform/SentryE2ETest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts ktlint's default
ktlint_officialcode style across the repo, completing the formatting migration that was deliberately deferred out of #556.When #556 bumped Spotless 7 / ktlint 1.x, the new default style would have reformatted ~150 files and buried the toolchain changes, so #556 pinned the legacy
intellij_ideastyle instead (viaeditorConfigOverride, since Spotless does not forwardij_*properties from.editorconfigto ktlint). This PR deletes that pin and applies the resulting reformat in isolation, where reviewers can verify it is pure formatting.What
build.gradle.kts(back to plainktlint()) and.editorconfig(the function/property-naming disables stay — backtick test names predate those rules).spotlessApplyacross the repo (~146 files: multiline expression wrapping, trailing commas, signature wrapping, expression bodies).: Unitreturn type inSentryKMP.captureUserFeedbackrequired by explicit-api mode after the expression-body conversion — the only hand-written source change.MaxLineLengthentries caused by the reformat)../gradlew detektBaseline: theDetektCreateBaselineTaskwas never wired to the repo sources/excludes, so regenerating the shared baseline silently did nothing.No functional change. Verified locally:
spotlessCheck,detekt, JVM/iOS/macOS compiles, and the full Gradle plugin test suite.#skip-changelog