fix(catalog): Prevent ApiClientError from being logged as server bug - #1155
Open
sentry[bot] wants to merge 1 commit into
Open
fix(catalog): Prevent ApiClientError from being logged as server bug#1155sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
update_projecttool inpackages/mcp-core/src/tools/catalog/update-project.tswas unconditionally callinglogIssue(err)in its catch block. This led toApiClientErrorinstances (which represent 4xx HTTP responses due to invalid user input, e.g., bad slugs) being reported to Sentry as high-priority server bugs.This change modifies the catch block to check if the error is an
ApiClientError. If it is, the error is re-thrown directly, allowing the MCP framework's existing error handling (which correctly formatsApiClientErroras an "Input Error" for the user and does not log it to Sentry) to take over. This prevents expected user input validation errors from cluttering Sentry with false positives.Fixes MCP-SERVER-G3D
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.