fix(mcp-core): Handle missing thread_metadata in TransactionProfileSchema - #1221
Open
sentry[bot] wants to merge 1 commit into
Open
fix(mcp-core): Handle missing thread_metadata in TransactionProfileSchema#1221sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
ZodErroroccurring whenSentryApiService.getTransactionProfile(index)attempts to validate Sentry V1 profiling API responses. TheTransactionProfileSchemainpackages/mcp-core/src/api-client/schema.tsexpectedprofile.thread_metadatato always be a record, but the V1 API can sometimes omit this field or send it asnull.The fix involves updating
TransactionProfileSchemato usez.preprocess((value) => value ?? {}, ProfileThreadMetadataSchema)for thethread_metadatafield. This ensures that ifthread_metadatais missing ornull, it defaults to an empty object{}, preventing validation failures. This approach mirrors the existing handling for the same field inProfileChunkSchemawithin the same file.Fixes MCP-SERVER-FSD
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.