fix(database): run cache cleanup unconditionally, remove orphan dirs immediately

sentry__cleanup_cache must run regardless of cache_keep/http_retry
since large attachment dirs now live in the cache directory and need
cleanup even when caching is disabled.

Orphaned attachment dirs (no matching .envelope) are unconditionally
useless — remove them immediately instead of age-gating.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: jpnurmi

src/sentry_core.c

@@ -290,9 +290,7 @@ sentry_init(sentry_options_t *options)
         backend->prune_database_func(backend);
     }
 
-    if (options->cache_keep || options->http_retry) {
-        sentry__cleanup_cache(options);
-    }
+    sentry__cleanup_cache(options);
 
     if (options->auto_session_tracking) {
         sentry_start_session();

src/sentry_database.c

@@ -709,43 +709,37 @@ sentry__cleanup_cache(const sentry_options_t *options)
 
     sentry_free(entries);
 
-    // Second pass: age-prune orphaned attachment directories
+    // Second pass: remove orphaned attachment directories
     // (dirs without a matching .envelope, e.g. envelope deleted by
     // materialization failure or TUS disabled)
-    if (options->cache_max_age > 0) {
-        iter = sentry__path_iter_directory(cache_dir);
-        while (iter && (entry = sentry__pathiter_next(iter)) != NULL) {
-            if (!sentry__path_is_dir(entry)) {
-                continue;
-            }
-            const char *dirname = sentry__path_filename(entry);
-            if (!dirname || strlen(dirname) != 36) {
-                continue;
-            }
-            time_t dir_mtime = sentry__path_get_mtime(entry);
-            if (dir_mtime >= oldest_allowed) {
+    iter = sentry__path_iter_directory(cache_dir);
+    while (iter && (entry = sentry__pathiter_next(iter)) != NULL) {
+        if (!sentry__path_is_dir(entry)) {
+            continue;
+        }
+        const char *dirname = sentry__path_filename(entry);
+        if (!dirname || strlen(dirname) != 36) {
+            continue;
+        }
+        bool has_envelope = false;
+        sentry_pathiter_t *fiter = sentry__path_iter_directory(cache_dir);
+        const sentry_path_t *f;
+        while (fiter && (f = sentry__pathiter_next(fiter)) != NULL) {
+            if (sentry__path_is_dir(f)) {
                 continue;
             }
-            bool has_envelope = false;
-            sentry_pathiter_t *fiter = sentry__path_iter_directory(cache_dir);
-            const sentry_path_t *f;
-            while (fiter && (f = sentry__pathiter_next(fiter)) != NULL) {
-                if (sentry__path_is_dir(f)) {
-                    continue;
-                }
-                const char *fname = sentry__path_filename(f);
-                if (fname && strstr(fname, dirname)) {
-                    has_envelope = true;
-                    break;
-                }
-            }
-            sentry__pathiter_free(fiter);
-            if (!has_envelope) {
-                sentry__path_remove_all(entry);
+            const char *fname = sentry__path_filename(f);
+            if (fname && strstr(fname, dirname)) {
+                has_envelope = true;
+                break;
             }
         }
-        sentry__pathiter_free(iter);
+        sentry__pathiter_free(fiter);
+        if (!has_envelope) {
+            sentry__path_remove_all(entry);
+        }
     }
+    sentry__pathiter_free(iter);
 
     sentry__path_free(cache_dir);
 }