Skip to content

Commit f230fa2

Browse files
authored
test: disable test_inproc_concurrent_crash_repeated in tsan (#1537)
* test: disable test_inproc_concurrent_crash_repeated in tsan * test: also disable the single run cousin
1 parent 9d81818 commit f230fa2

1 file changed

Lines changed: 10 additions & 1 deletion

File tree

tests/test_inproc_stress.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77
import time
88

99
import pytest
10-
from flaky import flaky
1110

1211
from . import Envelope
1312
from .assertions import assert_inproc_crash
1413
from .build_config import get_test_executable_cmake_args, get_test_executable_env
14+
from .conditions import is_tsan
1515

1616
fixture_path = pathlib.Path("tests/fixtures/inproc_stress")
1717

@@ -222,6 +222,9 @@ def test_inproc_simple_crash(cmake):
222222
shutil.rmtree(database_path, ignore_errors=True)
223223

224224

225+
@pytest.mark.skipif(
226+
is_tsan, reason="disabled in tsan due to triggering edge-case flaky behavior"
227+
)
225228
def test_inproc_concurrent_crash(cmake):
226229
"""
227230
Stress test: multiple threads crash simultaneously.
@@ -482,7 +485,13 @@ def test_inproc_stack_trace(cmake, test_name, expected_functions, expect_no_dupl
482485

483486

484487
@pytest.mark.parametrize("iteration", range(5))
488+
@pytest.mark.skipif(
489+
is_tsan, reason="disabled in tsan due to triggering edge-case flaky behavior"
490+
)
485491
def test_inproc_concurrent_crash_repeated(cmake, iteration):
492+
"""
493+
minimal assertions version of test_inproc_concurrent_crash that just hits multiple times each CI run.
494+
"""
486495
tmp_path = cmake(
487496
["sentry"],
488497
{"SENTRY_BACKEND": "inproc", "SENTRY_TRANSPORT": "none"},

0 commit comments

Comments
 (0)