Do not call Reflection*::setAccessible() in PHP >= 8.1 (#1872)

Author: W0rma

src/ErrorHandler.php

@@ -153,7 +153,9 @@ final class ErrorHandler
     private function __construct()
     {
         $this->exceptionReflection = new \ReflectionProperty(\Exception::class, 'trace');
-        $this->exceptionReflection->setAccessible(true);
+        if (\PHP_VERSION_ID < 80100) {
+            $this->exceptionReflection->setAccessible(true);
+        }
     }
 
     /**

src/functions.php

@@ -29,7 +29,7 @@
  *     capture_silenced_errors?: bool,
  *     context_lines?: int|null,
  *     default_integrations?: bool,
- *     dsn?: string|bool|null|Dsn,
+ *     dsn?: string|bool|Dsn|null,
  *     enable_logs?: bool,
  *     environment?: string|null,
  *     error_types?: int|null,

tests/FrameBuilderTest.php

@@ -300,12 +300,16 @@ public function testGetFunctionArgumentsWithVariadicParameters(): void
 
         $reflectionClass = new \ReflectionClass($frameBuilder);
         $getFunctionArgumentsMethod = $reflectionClass->getMethod('getFunctionArguments');
-        $getFunctionArgumentsMethod->setAccessible(true);
+        if (\PHP_VERSION_ID < 80100) {
+            $getFunctionArgumentsMethod->setAccessible(true);
+        }
 
         $reflectionFunction = new \ReflectionFunction($testFunction);
 
         $getFunctionArgumentValuesMethod = $reflectionClass->getMethod('getFunctionArgumentValues');
-        $getFunctionArgumentValuesMethod->setAccessible(true);
+        if (\PHP_VERSION_ID < 80100) {
+            $getFunctionArgumentValuesMethod->setAccessible(true);
+        }
 
         $result = $getFunctionArgumentValuesMethod->invoke($frameBuilder, $reflectionFunction, $backtraceFrame['args']);
 
@@ -331,7 +335,9 @@ public function testGetFunctionArgumentsWithOnlyVariadicParameters(): void
 
         $reflectionClass = new \ReflectionClass($frameBuilder);
         $getFunctionArgumentValuesMethod = $reflectionClass->getMethod('getFunctionArgumentValues');
-        $getFunctionArgumentValuesMethod->setAccessible(true);
+        if (\PHP_VERSION_ID < 80100) {
+            $getFunctionArgumentValuesMethod->setAccessible(true);
+        }
 
         $reflectionFunction = new \ReflectionFunction($testFunction);
 
@@ -356,7 +362,9 @@ public function testGetFunctionArgumentsWithEmptyVariadicParameters(): void
 
         $reflectionClass = new \ReflectionClass($frameBuilder);
         $getFunctionArgumentValuesMethod = $reflectionClass->getMethod('getFunctionArgumentValues');
-        $getFunctionArgumentValuesMethod->setAccessible(true);
+        if (\PHP_VERSION_ID < 80100) {
+            $getFunctionArgumentValuesMethod->setAccessible(true);
+        }
 
         $reflectionFunction = new \ReflectionFunction($testFunction);
 
@@ -383,7 +391,9 @@ public function testGetFunctionArgumentsWithNullValues(): void
 
         $reflectionClass = new \ReflectionClass($frameBuilder);
         $getFunctionArgumentValuesMethod = $reflectionClass->getMethod('getFunctionArgumentValues');
-        $getFunctionArgumentValuesMethod->setAccessible(true);
+        if (\PHP_VERSION_ID < 80100) {
+            $getFunctionArgumentValuesMethod->setAccessible(true);
+        }
 
         $reflectionFunction = new \ReflectionFunction($testFunction);
 
@@ -418,7 +428,9 @@ public function testGetFunctionArgumentsWithGapsInBacktraceArrayIndices(): void
 
         $reflectionClass = new \ReflectionClass($frameBuilder);
         $getFunctionArgumentValuesMethod = $reflectionClass->getMethod('getFunctionArgumentValues');
-        $getFunctionArgumentValuesMethod->setAccessible(true);
+        if (\PHP_VERSION_ID < 80100) {
+            $getFunctionArgumentValuesMethod->setAccessible(true);
+        }
 
         $reflectionFunction = new \ReflectionFunction($testFunction);
 

tests/SentrySdkExtension.php

@@ -14,18 +14,30 @@ final class SentrySdkExtension implements BeforeTestHookInterface
     public function executeBeforeTest(string $test): void
     {
         $reflectionProperty = new \ReflectionProperty(SentrySdk::class, 'currentHub');
-        $reflectionProperty->setAccessible(true);
+        if (\PHP_VERSION_ID < 80100) {
+            $reflectionProperty->setAccessible(true);
+        }
         $reflectionProperty->setValue(null, null);
-        $reflectionProperty->setAccessible(false);
+        if (\PHP_VERSION_ID < 80100) {
+            $reflectionProperty->setAccessible(false);
+        }
 
         $reflectionProperty = new \ReflectionProperty(Scope::class, 'globalEventProcessors');
-        $reflectionProperty->setAccessible(true);
+        if (\PHP_VERSION_ID < 80100) {
+            $reflectionProperty->setAccessible(true);
+        }
         $reflectionProperty->setValue(null, []);
-        $reflectionProperty->setAccessible(false);
+        if (\PHP_VERSION_ID < 80100) {
+            $reflectionProperty->setAccessible(false);
+        }
 
         $reflectionProperty = new \ReflectionProperty(IntegrationRegistry::class, 'integrations');
-        $reflectionProperty->setAccessible(true);
+        if (\PHP_VERSION_ID < 80100) {
+            $reflectionProperty->setAccessible(true);
+        }
         $reflectionProperty->setValue(IntegrationRegistry::getInstance(), []);
-        $reflectionProperty->setAccessible(false);
+        if (\PHP_VERSION_ID < 80100) {
+            $reflectionProperty->setAccessible(false);
+        }
     }
 }