ref: remove polyfill (#1922)

Author: Litarnus

phpstan-baseline.neon

@@ -1,5 +1,8 @@
 parameters:
 	ignoreErrors:
+		-
+			message: "#.*#"
+			path: src/Util/DebugType.php
 		-
 			message: "#^Method Sentry\\\\Client\\:\\:getIntegration\\(\\) should return \\(T of Sentry\\\\Integration\\\\IntegrationInterface\\)\\|null but returns \\(T of Sentry\\\\Integration\\\\IntegrationInterface\\)\\|null\\.$#"
 			count: 1

psalm.xml.dist

@@ -10,6 +10,7 @@
         <directory name="src" />
         <ignoreFiles>
             <directory name="vendor" />
+            <file name="src/Util/DebugType.php" />
         </ignoreFiles>
     </projectFiles>
 

src/CheckInStatus.php

@@ -7,7 +7,7 @@
 /**
  * This enum represents all the possible status of a check in.
  */
-final class CheckInStatus implements \Stringable
+final class CheckInStatus
 {
     /**
      * @var string The value of the enum instance

src/Dsn.php

@@ -10,7 +10,7 @@
  *
  * @author Stefano Arlandini <sarlandini@alice.it>
  */
-final class Dsn implements \Stringable
+final class Dsn
 {
     /**
      * @var string Regex to match the organization ID in the host.

src/Event.php

@@ -9,6 +9,7 @@
 use Sentry\Logs\Log;
 use Sentry\Profiling\Profile;
 use Sentry\Tracing\Span;
+use Sentry\Util\DebugType;
 
 /**
  * This is the base class for classes containing event data.
@@ -802,7 +803,7 @@ public function setExceptions(array $exceptions): self
     {
         foreach ($exceptions as $exception) {
             if (!$exception instanceof ExceptionDataBag) {
-                throw new \UnexpectedValueException(\sprintf('Expected an instance of the "%s" class. Got: "%s".', ExceptionDataBag::class, get_debug_type($exception)));
+                throw new \UnexpectedValueException(\sprintf('Expected an instance of the "%s" class. Got: "%s".', ExceptionDataBag::class, DebugType::getDebugType($exception)));
             }
         }
 

src/EventHint.php

@@ -4,6 +4,8 @@
 
 namespace Sentry;
 
+use Sentry\Util\DebugType;
+
 /**
  * This class represents hints on how to process an event.
  */
@@ -56,19 +58,19 @@ public static function fromArray(array $hintData): self
         $extra = $hintData['extra'] ?? [];
 
         if ($exception !== null && !$exception instanceof \Throwable) {
-            throw new \InvalidArgumentException(\sprintf('The value of the "exception" field must be an instance of a class implementing the "%s" interface. Got: "%s".', \Throwable::class, get_debug_type($exception)));
+            throw new \InvalidArgumentException(\sprintf('The value of the "exception" field must be an instance of a class implementing the "%s" interface. Got: "%s".', \Throwable::class, DebugType::getDebugType($exception)));
         }
 
         if ($mechanism !== null && !$mechanism instanceof ExceptionMechanism) {
-            throw new \InvalidArgumentException(\sprintf('The value of the "mechanism" field must be an instance of the "%s" class. Got: "%s".', ExceptionMechanism::class, get_debug_type($mechanism)));
+            throw new \InvalidArgumentException(\sprintf('The value of the "mechanism" field must be an instance of the "%s" class. Got: "%s".', ExceptionMechanism::class, DebugType::getDebugType($mechanism)));
         }
 
         if ($stacktrace !== null && !$stacktrace instanceof Stacktrace) {
-            throw new \InvalidArgumentException(\sprintf('The value of the "stacktrace" field must be an instance of the "%s" class. Got: "%s".', Stacktrace::class, get_debug_type($stacktrace)));
+            throw new \InvalidArgumentException(\sprintf('The value of the "stacktrace" field must be an instance of the "%s" class. Got: "%s".', Stacktrace::class, DebugType::getDebugType($stacktrace)));
         }
 
         if (!\is_array($extra)) {
-            throw new \InvalidArgumentException(\sprintf('The value of the "extra" field must be an array. Got: "%s".', get_debug_type($extra)));
+            throw new \InvalidArgumentException(\sprintf('The value of the "extra" field must be an array. Got: "%s".', DebugType::getDebugType($extra)));
         }
 
         $hint->exception = $exception;

src/EventId.php

@@ -11,7 +11,7 @@
  *
  * @author Stefano Arlandini <sarlandini@alice.it>
  */
-final class EventId implements \Stringable
+final class EventId
 {
     /**
      * @var string The ID

src/EventType.php

@@ -10,7 +10,7 @@
  *
  * @author Stefano Arlandini <sarlandini@alice.it>
  */
-final class EventType implements \Stringable
+final class EventType
 {
     /**
      * @var string The value of the enum instance

src/FrameBuilder.php

@@ -179,7 +179,7 @@ private function getFunctionArguments(array $backtraceFrame): array
                 } else {
                     $reflectionFunction = new \ReflectionMethod($backtraceFrame['class'], '__call');
                 }
-            } elseif ($backtraceFrame['function'] !== '__lambda_func' && !str_starts_with($backtraceFrame['function'], '{closure') && \function_exists($backtraceFrame['function'])) {
+            } elseif ($backtraceFrame['function'] !== '__lambda_func' && strpos($backtraceFrame['function'], '{closure') !== 0 && \function_exists($backtraceFrame['function'])) {
                 $reflectionFunction = new \ReflectionFunction($backtraceFrame['function']);
             }
         } catch (\ReflectionException $e) {

src/Integration/IntegrationRegistry.php

@@ -6,6 +6,7 @@
 
 use Psr\Log\LoggerInterface;
 use Sentry\Options;
+use Sentry\Util\DebugType;
 
 /**
  * @internal
@@ -123,7 +124,7 @@ private function getIntegrationsToSetup(Options $options): array
             $integrations = $userIntegrations($defaultIntegrations);
 
             if (!\is_array($integrations)) {
-                throw new \UnexpectedValueException(\sprintf('Expected the callback set for the "integrations" option to return a list of integrations. Got: "%s".', get_debug_type($integrations)));
+                throw new \UnexpectedValueException(\sprintf('Expected the callback set for the "integrations" option to return a list of integrations. Got: "%s".', DebugType::getDebugType($integrations)));
             }
         }