Add failing tests

Author: stayallive

src/Logs/LogsAggregator.php

@@ -124,6 +124,14 @@ public function flush(): ?EventId
         return $hub->captureEvent($event);
     }
 
+    /**
+     * @return Log[]
+     */
+    public function all(): array
+    {
+        return $this->logs;
+    }
+
     private function getTraceId(HubInterface $hub): string
     {
         $span = $hub->getSpan();

tests/Logs/LogTest.php

@@ -5,14 +5,9 @@
 namespace Sentry\Tests\Logs;
 
 use PHPUnit\Framework\TestCase;
-use Sentry\Attributes\Attribute;
 use Sentry\Logs\Log;
 use Sentry\Logs\LogLevel;
 
-/**
- * @phpstan-import-type AttributeValue from Attribute
- * @phpstan-import-type AttributeSerialized from Attribute
- */
 final class LogTest extends TestCase
 {
     public function testGettersAndSetters(): void

tests/Logs/LogsAggregatorTest.php

@@ -0,0 +1,67 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Sentry\Tests\Logs;
+
+use PHPUnit\Framework\TestCase;
+use Sentry\ClientBuilder;
+use Sentry\Logs\LogLevel;
+use Sentry\Logs\LogsAggregator;
+use Sentry\SentrySdk;
+use Sentry\State\Hub;
+
+final class LogsAggregatorTest extends TestCase
+{
+    /**
+     * @dataProvider messageFormattingDataProvider
+     */
+    public function testMessageFormatting(string $message, array $values, string $expected): void
+    {
+        $client = ClientBuilder::create([
+            'enable_logs' => true,
+        ])->getClient();
+
+        $hub = new Hub($client);
+        SentrySdk::setCurrentHub($hub);
+
+        $aggregator = new LogsAggregator();
+
+        $aggregator->add(LogLevel::info(), $message, $values);
+
+        $logs = $aggregator->all();
+
+        $this->assertCount(1, $logs);
+
+        $log = $logs[0];
+
+        $this->assertEquals($expected, $log->getBody());
+    }
+
+    public static function messageFormattingDataProvider(): \Generator
+    {
+        yield [
+            'Simple message without values',
+            [],
+            'Simple message without values',
+        ];
+
+        yield [
+            'Message with a value: %s',
+            ['value'],
+            'Message with a value: value',
+        ];
+
+        yield [
+            'Message with placeholders but no values: %s',
+            [],
+            'Message with placeholders but no values: %s',
+        ];
+
+        yield [
+            'Message with placeholders but incorrect number of values: %s, %s',
+            ['value'],
+            'Message with placeholders but incorrect number of values: %s, %s',
+        ];
+    }
+}