fix(pii): remove guards from aggregators (#2083)

Author: Litarnus

src/Logs/LogsAggregator.php

@@ -90,22 +90,20 @@ public function add(
             $log->setAttribute('sentry.sdk.version', $client->getSdkVersion());
         }
 
-        if ($options->shouldSendDefaultPii()) {
-            $hub->configureScope(static function (Scope $scope) use ($log) {
-                $user = $scope->getUser();
-                if ($user !== null) {
-                    if ($user->getId() !== null) {
-                        $log->setAttribute('user.id', $user->getId());
-                    }
-                    if ($user->getEmail() !== null) {
-                        $log->setAttribute('user.email', $user->getEmail());
-                    }
-                    if ($user->getUsername() !== null) {
-                        $log->setAttribute('user.name', $user->getUsername());
-                    }
+        $hub->configureScope(static function (Scope $scope) use ($log) {
+            $user = $scope->getUser();
+            if ($user !== null) {
+                if ($user->getId() !== null) {
+                    $log->setAttribute('user.id', $user->getId());
                 }
-            });
-        }
+                if ($user->getEmail() !== null) {
+                    $log->setAttribute('user.email', $user->getEmail());
+                }
+                if ($user->getUsername() !== null) {
+                    $log->setAttribute('user.name', $user->getUsername());
+                }
+            }
+        });
 
         if (\count($values)) {
             $log->setAttribute('sentry.message.template', $message);

src/Metrics/MetricsAggregator.php

@@ -81,22 +81,20 @@ public function add(
                 $defaultAttributes['sentry.sdk.version'] = $client->getSdkVersion();
             }
 
-            if ($options->shouldSendDefaultPii()) {
-                $hub->configureScope(static function (Scope $scope) use (&$defaultAttributes) {
-                    $user = $scope->getUser();
-                    if ($user !== null) {
-                        if ($user->getId() !== null) {
-                            $defaultAttributes['user.id'] = $user->getId();
-                        }
-                        if ($user->getEmail() !== null) {
-                            $defaultAttributes['user.email'] = $user->getEmail();
-                        }
-                        if ($user->getUsername() !== null) {
-                            $defaultAttributes['user.name'] = $user->getUsername();
-                        }
+            $hub->configureScope(static function (Scope $scope) use (&$defaultAttributes) {
+                $user = $scope->getUser();
+                if ($user !== null) {
+                    if ($user->getId() !== null) {
+                        $defaultAttributes['user.id'] = $user->getId();
                     }
-                });
-            }
+                    if ($user->getEmail() !== null) {
+                        $defaultAttributes['user.email'] = $user->getEmail();
+                    }
+                    if ($user->getUsername() !== null) {
+                        $defaultAttributes['user.name'] = $user->getUsername();
+                    }
+                }
+            });
 
             $release = $options->getRelease();
             if ($release !== null) {

tests/Logs/LogsAggregatorTest.php

@@ -211,7 +211,7 @@ public function testAttributesAreAddedToLogMessage(): void
         $this->assertSame('my_user', $attributes->get('user.name')->getValue());
     }
 
-    public function testUserAttributesAreNotAddedToLogMessageWhenSendDefaultPiiIsDisabled(): void
+    public function testUserAttributesCanBeSetManuallyWithDefaultPiiOff(): void
     {
         $client = ClientBuilder::create([
             'enable_logs' => true,
@@ -237,9 +237,9 @@ public function testUserAttributesAreNotAddedToLogMessageWhenSendDefaultPiiIsDis
 
         $attributes = $logs[0]->attributes();
 
-        $this->assertNull($attributes->get('user.id'));
-        $this->assertNull($attributes->get('user.email'));
-        $this->assertNull($attributes->get('user.name'));
+        $this->assertSame('unique_id', $attributes->get('user.id')->getValue());
+        $this->assertSame('foo@example.com', $attributes->get('user.email')->getValue());
+        $this->assertSame('my_user', $attributes->get('user.name')->getValue());
     }
 
     public function testFlushesImmediatelyWhenThresholdIsReached(): void