Skip to content

Do not call Reflection*::setAccessible() in PHP >= 8.1#1872

Merged
cleptric merged 2 commits into
getsentry:masterfrom
W0rma:reflection-set-accessible
Aug 5, 2025
Merged

Do not call Reflection*::setAccessible() in PHP >= 8.1#1872
cleptric merged 2 commits into
getsentry:masterfrom
W0rma:reflection-set-accessible

Conversation

@W0rma
Copy link
Copy Markdown
Contributor

@W0rma W0rma commented Aug 1, 2025

As of PHP 8.1.0, calling this method has no effect; all methods are invokable by default.

(https://www.php.net/manual/en/reflectionmethod.setaccessible.php and https://www.php.net/manual/en/reflectionproperty.setaccessible.php).

There're even plans to deprecate the method in PHP 8.5: https://wiki.php.net/rfc/deprecations_php_8_5#extreflection_deprecations

@stayallive stayallive requested a review from cleptric August 5, 2025 03:25
@cleptric cleptric merged commit 23f25f1 into getsentry:master Aug 5, 2025
39 checks passed
@W0rma W0rma deleted the reflection-set-accessible branch August 5, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants