Refactor trace header parsing logic#1876
Merged
Merged
Conversation
cleptric
commented
Aug 11, 2025
Comment on lines
+313
to
+317
| - | ||
| message: "#^Property Sentry\\\\Tracing\\\\PropagationContext\\:\\:\\$parentSampled is never read, only written\\.$#" | ||
| count: 1 | ||
| path: src/Tracing/PropagationContext.php | ||
|
|
Member
Author
There was a problem hiding this comment.
Didn't find an elegant way to fix this
Litarnus
approved these changes
Aug 11, 2025
Contributor
|
Can we use it somewhere else too? If not it might be more explicit to have a regular class instead of a Trait |
Member
Author
|
We use it in two places. Kinda want to avoid sub-classing. Though we could also make it static tbh. |
Member
Author
|
Ahh, nvm, we can't. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bit overdue to clean this up.