Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Options.php
Original file line number Diff line number Diff line change
Expand Up @@ -1457,13 +1457,13 @@ private function validateDsnOption($dsn): bool
}

/**
* Validates if the value of the max_breadcrumbs option is in range.
* Validates if the value of the max_breadcrumbs option is valid.
*
* @param int $value The value to validate
*/
private function validateMaxBreadcrumbsOptions(int $value): bool
{
return $value >= 0 && $value <= self::DEFAULT_MAX_BREADCRUMBS;
Comment thread
FeBe95 marked this conversation as resolved.
return $value >= 0;
}

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/OptionsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@ public static function maxBreadcrumbsOptionIsValidatedCorrectlyDataProvider(): a
[true, 0],
[true, 1],
[true, Options::DEFAULT_MAX_BREADCRUMBS],
[false, Options::DEFAULT_MAX_BREADCRUMBS + 1],
[true, Options::DEFAULT_MAX_BREADCRUMBS + 1],
[false, 'string'],
[false, '1'],
];
Expand Down
Loading