Skip to content

Add support for Symfony 8 #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Litarnus merged 1 commit into from
Oct 28, 2025
+1 −1
Merged

Add support for Symfony 8 #1895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"guzzlehttp/psr7": "^1.8.4|^2.1.1",
"jean85/pretty-package-versions": "^1.5|^2.0.4",
"psr/log": "^1.0|^2.0|^3.0",
"symfony/options-resolver": "^4.4.30|^5.0.11|^6.0|^7.0"
"symfony/options-resolver": "^4.4.30|^5.0.11|^6.0|^7.0|^8.0"
},
Copy link
Copy Markdown

@sentry sentry Bot Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The composer.json PHP requirement ^7.2|^8.0 is incompatible with Symfony 8.0's options-resolver requiring PHP 8.2+.
Severity: CRITICAL | Confidence: 1.00

🔍 Detailed Analysis

The composer.json declares a PHP requirement of ^7.2|^8.0, allowing PHP versions from 7.2 up to 8.x. However, the symfony/options-resolver: ^8.0 dependency, introduced by this change, requires PHP 8.2 or higher. This creates an incompatible constraint. Users on PHP 8.0 or 8.1 will either encounter dependency resolution failures during composer install or experience runtime errors when the SDK attempts to use OptionsResolver if installation somehow succeeds.

💡 Suggested Fix

Update the composer.json PHP requirement to `

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: composer.json#L33

Potential issue: The `composer.json` declares a PHP requirement of `^7.2|^8.0`, allowing
PHP versions from 7.2 up to 8.x. However, the `symfony/options-resolver: ^8.0`
dependency, introduced by this change, requires PHP 8.2 or higher. This creates an
incompatible constraint. Users on PHP 8.0 or 8.1 will either encounter dependency
resolution failures during `composer install` or experience runtime errors when the SDK
attempts to use `OptionsResolver` if installation somehow succeeds.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Copy Markdown

@garak garak Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is completely wrong. The AI doesn't understand how semantic versioning works.

Copy link
Copy Markdown
Contributor

@Litarnus Litarnus Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, 100% agreed

"require-dev": {
"friendsofphp/php-cs-fixer": "^3.4",
Expand Down
Loading