CI cleanup#1901
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: PHP Version Mismatch Causes Analysis Inconsistency
The psalm static analysis job uses PHP 8.3, while php-cs-fixer and phpstan jobs were updated to PHP 8.4. This inconsistency, likely an oversight from the intended PHP 8.4 version bump, may lead to inconsistent static analysis results.
.github/workflows/static-analysis.yaml#L59-L60
sentry-php/.github/workflows/static-analysis.yaml
Lines 59 to 60 in 50970fa
Litarnus
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumped PHP versions to 8.4 and cleaned up some things. Our currently used psalm version is not compatible with 8.4, and bumping psalm to latest results in 500+ errors. We'll tackle this at a later date.