feat: add attachment support#1925
Merged
Merged
Conversation
stayallive
approved these changes
Oct 14, 2025
stayallive
left a comment
stayallive
left a comment
Collaborator
There was a problem hiding this comment.
Single suggestion but nothing major. Looks good to me!
| switch ($event->getType()) { | ||
| case EventType::event(): | ||
| $items[] = EventItem::toEnvelopeItem($event); | ||
| $items[] = AttachmentItem::toEnvelopeItem($event); |
Collaborator
There was a problem hiding this comment.
For clarity I think I would go for this (also in the transaction) instead and move the loop here. Yes it's a little more duplicated code but I think the clarity is a little better to also keep all the toEnvelopeItem methods returning a single item instead of multiple or none.
Suggested change
| $items[] = AttachmentItem::toEnvelopeItem($event); | |
| foreach ($event->getAttachments() as $attachment) { | |
| $items[] = AttachmentItem::toEnvelopeItem($attachment); | |
| } |
Contributor
Author
There was a problem hiding this comment.
True, very good point!
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing attachment support for PHP!
Attachments can be set on Scopes and will be added to Errors and Transaction events when sending them to sentry.
The PR currently does not enforce limits and reads the entire attachment content in memory before sending it. There is room for improvement such as respecting attachment limits as well as streaming the envelope to reduce the memory impact.